Attachment 27260 Details for Bug 22512 – Properly zero high quadword of %xmm0 before issuing a vector multiplication

[patch] Properly zero high quadword of %xmm0 before issuing a vector multiplication

0001-SSE-asm-fix-transform_points_3d_no_rot-using-undefin.patch (text/plain), 1.31 KB, created by Arthur Huillet on 2009-06-30 04:35:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Arthur Huillet

Created: 2009-06-30 04:35:25 UTC

Size: 1.31 KB

patch

obsolete

>From 72d525269094ab928154a9374cb17b51e7961e56 Mon Sep 17 00:00:00 2001
>From: Arthur HUILLET <arthur.huillet@free.fr>
>Date: Tue, 30 Jun 2009 12:46:27 +0200
>Subject: [PATCH] SSE asm: fix transform_points_3d_no_rot using undefined values in %xmm0
>
>Signed-off-by: Arthur HUILLET <arthur.huillet@free.fr>
>---
> src/mesa/x86/sse_xform2.S |    1 +
> src/mesa/x86/sse_xform3.S |    1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/src/mesa/x86/sse_xform2.S b/src/mesa/x86/sse_xform2.S
>index 91b82e7..b490d4c 100644
>--- a/src/mesa/x86/sse_xform2.S
>+++ b/src/mesa/x86/sse_xform2.S
>@@ -186,6 +186,7 @@ GLNAME(_mesa_sse_transform_points2_3d_no_rot):
>     MOV_L( REGOFF(V4F_START, EDI), EDI ) 	/* ptr to first dest vertex */
>     ADD_L( EDI, ECX ) 				/* count += dest ptr */
> 
>+    PXOR( XMM0, XMM0 )
> 
> ALIGNTEXT32
>     MOVSS    ( M(0), XMM1 )			/* - | - |  -  | m0  */
>diff --git a/src/mesa/x86/sse_xform3.S b/src/mesa/x86/sse_xform3.S
>index 1fc79ef..8a79eed 100644
>--- a/src/mesa/x86/sse_xform3.S
>+++ b/src/mesa/x86/sse_xform3.S
>@@ -198,6 +198,7 @@ GLNAME(_mesa_sse_transform_points3_3d_no_rot):
>     MOV_L( REGOFF(V4F_START, EDI), EDI ) 	/* ptr to first dest vertex */
>     ADD_L( EDI, ECX ) 				/* count += dest ptr */
> 
>+    PXOR( XMM0, XMM0 )
> 
> ALIGNTEXT32
>     MOVSS    ( M(0), XMM1 )			/* - | - |  -  | m0  */
>-- 
>1.6.3.2
>

Actions: View | Splinter Review

Attachments on bug 22512: 27260

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.