Attachment 27964 Details for Bug 22907 – Fixes regression in i830_dri.c introduced with the new DRI protocol 2.1

[patch] Fixes regression in i830_dri.c introduced with the new DRI protocol 2.1

kde43fix.patch (text/plain), 1.12 KB, created by Matthias Liertzer on 2009-07-23 20:04:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Liertzer

Created: 2009-07-23 20:04:11 UTC

Size: 1.12 KB

patch

obsolete

>diff --git a/src/i830_dri.c b/src/i830_dri.c
>index 40d11e4..6d8eb7d 100644
>--- a/src/i830_dri.c
>+++ b/src/i830_dri.c
>@@ -172,6 +172,8 @@ I830DRI2CreateBuffer(DrawablePtr pDraw, unsigned int attachment,
>     dri_bo *bo;
>     I830DRI2BufferPrivatePtr privates;
>     PixmapPtr pPixmap;
>+    static PixmapPtr pDepthPixmap = NULL;
>+    static DrawablePtr pDrawSave = NULL;
> 
>     buffer = xcalloc(1, sizeof *buffer);
>     if (buffer == NULL)
>@@ -182,9 +184,16 @@ I830DRI2CreateBuffer(DrawablePtr pDraw, unsigned int attachment,
> 	return NULL;
>     }
> 
>+    if(pDraw != pDrawSave) {
>+        pDepthPixmap = NULL;
>+	pDrawSave = pDraw;
>+    }
>     if (attachment == DRI2BufferFrontLeft) {
> 	pPixmap = get_drawable_pixmap(pDraw);
> 	pPixmap->refcnt++;
>+    } else if (attachment == DRI2BufferStencil && pDepthPixmap) {
>+        pPixmap = pDepthPixmap;
>+	pPixmap->refcnt++;
>     } else {
> 	unsigned int hint = 0;
> 
>@@ -216,6 +225,8 @@ I830DRI2CreateBuffer(DrawablePtr pDraw, unsigned int attachment,
> 
>     }
> 
>+    if (attachment == DRI2BufferDepth)
>+        pDepthPixmap = pPixmap;
> 
>     buffer->attachment = attachment;
>     buffer->pitch = pPixmap->devKind;

Actions: View | Splinter Review

Attachments on bug 22907: 27964 | 27965

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.