Attachment 29676 Details for Bug 24016 – Call _mesa_unpack_dudv_span_byte with the base internal format

[patch] Call _mesa_unpack_dudv_span_byte with the base internal format

0001-Call-_mesa_unpack_dudv_span_byte-with-the-base-inter.patch (text/plain), 1.23 KB, created by Ian Romanick on 2009-09-18 15:29:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Romanick

Created: 2009-09-18 15:29:06 UTC

Size: 1.23 KB

patch

obsolete

>From 8283292a78a8b01722e0fb33ac1b83c64d63cd69 Mon Sep 17 00:00:00 2001
>From: Ian Romanick <ian.d.romanick@intel.com>
>Date: Fri, 18 Sep 2009 15:20:52 -0700
>Subject: [PATCH] Call _mesa_unpack_dudv_span_byte with the base internal format
>
>It seems that the _mesa_unpack_* functions expect to be passed base
>formats (e.g., GL_RGBA instead of GL_RGBA8) for both the source and
>destination format.  However, _mesa_texstore_dudv8 passed the source
>format directly from the application.  This means that GL_DU8DV8_ATI
>could slip through.
>---
> src/mesa/main/texstore.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
>index ab9973b..abe5b92 100644
>--- a/src/mesa/main/texstore.c
>+++ b/src/mesa/main/texstore.c
>@@ -2543,7 +2543,7 @@ _mesa_texstore_dudv8(TEXSTORE_PARAMS)
>       dst = tempImage;
>       for (row = 0; row < srcHeight; row++) {
>          _mesa_unpack_dudv_span_byte(ctx, srcWidth, baseInternalFormat,
>-                                     dst, srcFormat, srcType, src,
>+                                     dst, GL_DUDV_ATI, srcType, src,
>                                      srcPacking, 0);
>          dst += srcWidth * components;
>          src += srcStride;
>-- 
>1.6.3.3
>

Actions: View | Splinter Review

Attachments on bug 24016: 29674 | 29676 | 29719 | 29720 | 32441 | 32445

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.