Attachment 30414 Details for Bug 24531 – patch based on Kristian's strtod_l() suggestion

[patch] patch based on Kristian's strtod_l() suggestion

0001-mesa-use-C-locale-for-_mesa_strtod.patch (text/plain), 1.24 KB, created by Brian Paul on 2009-10-14 13:22:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brian Paul

Created: 2009-10-14 13:22:57 UTC

Size: 1.24 KB

patch

obsolete

>From 4d3d3aff6e5703f715b7a6160c16938a24cb67af Mon Sep 17 00:00:00 2001
>From: Brian Paul <brianp@vmware.com>
>Date: Wed, 14 Oct 2009 14:19:03 -0600
>Subject: [PATCH] mesa: use C locale for _mesa_strtod()
>
>_mesa_strtod() is used for shader/program parsing where the decimal
>point character is always '.'  Use strtod_l() with a "C" locale to
>ensure correct string->double conversion when the actual locale uses
>another character such as ',' for the decimal point.
>
>Fixes bug 24531.
>---
> src/mesa/main/imports.c |   12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
>diff --git a/src/mesa/main/imports.c b/src/mesa/main/imports.c
>index 6ffaddc..87cb5ce 100644
>--- a/src/mesa/main/imports.c
>+++ b/src/mesa/main/imports.c
>@@ -48,6 +48,10 @@
> #include "context.h"
> #include "version.h"
> 
>+#ifdef _GNU_SOURCE
>+#include <locale.h>
>+#endif
>+
> 
> #define MAXSTRING 4000  /* for vsnprintf() */
> 
>@@ -908,7 +912,15 @@ _mesa_atoi(const char *s)
> double
> _mesa_strtod( const char *s, char **end )
> {
>+#ifdef _GNU_SOURCE
>+   static locale_t loc = NULL;
>+   if (!loc) {
>+      loc = newlocale(LC_CTYPE_MASK, "C", NULL);
>+   }
>+   return strtod_l(s, end, loc);
>+#else
>    return strtod(s, end);
>+#endif
> }
> 
> /** Compute simple checksum/hash for a string */
>-- 
>1.5.4
>

Actions: View | Splinter Review

Attachments on bug 24531: 30410 | 30414 | 30419 | 41062

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.