Attachment 30570 Details for Bug 24576 – dmxDestroyWindow() - must call the X's native DetroyWindow()

[patch] dmxDestroyWindow() - must call the X's native DetroyWindow()

0001-dmxDestroyWindow-must-call-the-X-s-native-DetroyWind.patch (text/plain), 1.11 KB, created by Lee Leahu on 2009-10-19 13:45:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lee Leahu

Created: 2009-10-19 13:45:36 UTC

Size: 1.11 KB

patch

obsolete

>From 2cd775e35ad2c52caa128b963a13528fd829af77 Mon Sep 17 00:00:00 2001
>From: Lee Leahu <freedesktop-bugs@dyweni.com>
>Date: Mon, 19 Oct 2009 15:43:59 -0500
>Subject: [PATCH] dmxDestroyWindow() - must call the X's native DetroyWindow()
>
>Don't really know why this section was disabled, but without it,
>certain pPicture resources do not get free'd until later in the
>FreeClientResources() process after the screen has been free'd -
>resulting in seg fault.
>
>With this patch, all resources normally free'd using vanilla X are
>now also being freed correctly by Xdmx.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=24576
>---
> hw/dmx/dmxwindow.c |    3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
>diff --git a/hw/dmx/dmxwindow.c b/hw/dmx/dmxwindow.c
>index 24acc08..ec9a29a 100644
>--- a/hw/dmx/dmxwindow.c
>+++ b/hw/dmx/dmxwindow.c
>@@ -419,10 +419,9 @@ Bool dmxDestroyWindow(WindowPtr pWindow)
> 	pWinPriv->windowDestroyed(pWindow);
> #endif
> 
>-#if 0
>     if (pScreen->DestroyWindow)
> 	ret = pScreen->DestroyWindow(pWindow);
>-#endif
>+
>     DMX_WRAP(DestroyWindow, dmxDestroyWindow, dmxScreen, pScreen);
> 
>     return ret;
>-- 
>1.6.4.4
>

Actions: View | Splinter Review

Attachments on bug 24576: 30565 | 30566 | 30567 | 30570

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.