Attachment 30636 Details for Bug 24685 – Correctly compute DMXGetScreenAttributes reply length

[patch] Correctly compute DMXGetScreenAttributes reply length

0001-dmx-Correctly-compute-DMXGetScreenAttributes-reply-l.patch (text/plain), 1.15 KB, created by Jon Turney on 2009-10-23 06:40:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jon Turney

Created: 2009-10-23 06:40:06 UTC

Size: 1.15 KB

patch

obsolete

>From 1940ee59aab43a67707249ef483dd0b11dd6b679 Mon Sep 17 00:00:00 2001
>From: Jon TURNEY <jon.turney@dronecode.org.uk>
>Date: Fri, 23 Oct 2009 14:34:37 +0100
>Subject: [PATCH] dmx: Correctly compute DMXGetScreenAttributes reply length
>
>Correctly allow for excess length of DMXGetScreenAttributes reply
>over standard 32 byte reply in addition to the displayName string
>when computing the length of reply
>
>Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
>---
> hw/dmx/dmx.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/hw/dmx/dmx.c b/hw/dmx/dmx.c
>index b8fbf02..a1afe76 100644
>--- a/hw/dmx/dmx.c
>+++ b/hw/dmx/dmx.c
>@@ -362,7 +362,8 @@ static int ProcDMXGetScreenAttributes(ClientPtr client)
>     paddedLength            = pad_to_int32(length);
>     rep.type                = X_Reply;
>     rep.sequenceNumber      = client->sequence;
>-    rep.length              = bytes_to_int32(paddedLength);
>+    rep.length              = bytes_to_int32((sizeof(xDMXGetScreenAttributesReply) - sizeof(xGenericReply))
>+                                             + paddedLength);
>     rep.displayNameLength   = length;
> 
>     if (client->swapped) {
>-- 
>1.6.4.2
>

Actions: View | Splinter Review

Attachments on bug 24685: 30636

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.