Attachment 31463 Details for Bug 25274 – pm-functions.in: Drop $CHASSIS_TYPE

[patch] pm-functions.in: Drop $CHASSIS_TYPE

0004-pm-functions.in-Drop-CHASSIS_TYPE.patch (text/plain), 1.14 KB, created by Martin Pitt on 2009-11-25 03:37:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Pitt

Created: 2009-11-25 03:37:12 UTC

Size: 1.14 KB

patch

obsolete

>From 6f20e049f2fee06b6db4d034a2b4eedc90e7ab05 Mon Sep 17 00:00:00 2001
>From: Martin Pitt <martin.pitt@ubuntu.com>
>Date: Wed, 25 Nov 2009 12:35:28 +0100
>Subject: [PATCH 4/4] pm-functions.in: Drop $CHASSIS_TYPE
>
>$CHASSIS_TYPE is not used anywhere in pm-utils itself, nor any third-party
>pm-utils hook that I can see. It relies on a dmidecode map in hal which has
>never really been robust, and it just seems generally obsolete nowadays.
>
>Let's not proliferate that any further and just remove it entirely.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=25274
>---
> pm/pm-functions.in |    6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
>diff --git a/pm/pm-functions.in b/pm/pm-functions.in
>index 4c8bc7b..b8f7746 100644
>--- a/pm/pm-functions.in
>+++ b/pm/pm-functions.in
>@@ -79,12 +79,6 @@ done
> 
> . "${PM_FUNCTIONS}"
> 
>-if command_exists hal-get-property; then
>-    export CHASSIS_TYPE="$(hal-get-property --udi /org/freedesktop/Hal/devices/computer --key system.chassis.type 2>/dev/null || echo Unknown)"
>-else
>-    export CHASSIS_TYPE=Unknown
>-fi
>-
> # Simple little logging function.
> # We do it this way because 'echo -n' is not posix.
> log()
>-- 
>1.6.5
>

Actions: View | Splinter Review

Attachments on bug 25274: 31462 | 31463 | 31464

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.