Attachment 31544 Details for Bug 21501 – proposed patch

proposed patch

fix_fbos.diff (text/plain), 1.36 KB, created by Maciej Cencora on 2009-11-28 15:27:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Maciej Cencora

Created: 2009-11-28 15:27:47 UTC

Size: 1.36 KB

patch

obsolete

>diff --git a/src/mesa/drivers/dri/radeon/radeon_fbo.c b/src/mesa/drivers/dri/radeon/radeon_fbo.c
>index 7ec641f..fc21069 100644
>--- a/src/mesa/drivers/dri/radeon/radeon_fbo.c
>+++ b/src/mesa/drivers/dri/radeon/radeon_fbo.c
>@@ -369,6 +369,12 @@ radeon_framebuffer_renderbuffer(GLcontext * ctx,
> }
> 
> 
>+/* TODO: According to EXT_fbo spec internal format of texture image
>+ * once set during glTexImage call, should be preserved when
>+ * attaching image to renderbuffer. When HW doesn't support
>+ * rendering to format of attached image, set framebuffer
>+ * completeness accordingly in radeon_validate_framebuffer (issue #79).
>+ */
> static GLboolean
> radeon_update_wrapper(GLcontext *ctx, struct radeon_renderbuffer *rrb, 
> 		     struct gl_texture_image *texImage)
>diff --git a/src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c b/src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c
>index 9421104..405c6ac 100644
>--- a/src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c
>+++ b/src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c
>@@ -442,8 +442,11 @@ static void migrate_image_to_miptree(radeon_mipmap_tree *mt,
> 
> 		radeon_mipmap_level *srclvl = &image->mt->levels[image->mtlevel];
> 
>+		/* TODO: bring back these assertions once the FBOs are fixed */
>+#if 0
> 		assert(srclvl->size == dstlvl->size);
> 		assert(srclvl->rowstride == dstlvl->rowstride);
>+#endif
> 
> 		radeon_bo_map(image->mt->bo, GL_FALSE);
>

Actions: View

Attachments on bug 21501: 31476 | 31478 | 31535 | 31544

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.