Attachment 31696 Details for Bug 25374 – 0001-Xi-reset-device-properties-to-NULL-after-deleting-th.patch

[patch] 0001-Xi-reset-device-properties-to-NULL-after-deleting-th.patch

0001-Xi-reset-device-properties-to-NULL-after-deleting-th.patch (text/plain), 1.16 KB, created by Peter Hutterer on 2009-12-02 17:51:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Hutterer

Created: 2009-12-02 17:51:19 UTC

Size: 1.16 KB

patch

obsolete

>From b8321647e085191cb3694397cc7c53541c8a6cd0 Mon Sep 17 00:00:00 2001
>From: Peter Hutterer <peter.hutterer@who-t.net>
>Date: Thu, 3 Dec 2009 11:21:31 +1000
>Subject: [PATCH] Xi: reset device properties to NULL after deleting them. (#25374)
>
>Commit 0e6cee853d8e5bef3274e632ef034d37f14674a9 introduced cleanup code to
>remove the accel properties when switching schemes. The same code is
>triggered by the default closedown code but only after unconditionally
>removing all device properties (as part of the cleanup). The properties,
>although deleted never got reset to NULL.
>
>X.Org Bug 25374 <http://bugs.freedesktop.org/show_bug.cgi?id=25374>
>
>Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
>---
> Xi/xiproperty.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/Xi/xiproperty.c b/Xi/xiproperty.c
>index ecb326e..ea66c54 100644
>--- a/Xi/xiproperty.c
>+++ b/Xi/xiproperty.c
>@@ -622,6 +622,8 @@ XIDeleteAllDeviceProperties (DeviceIntPtr device)
>         XIDestroyDeviceProperty(prop);
>     }
> 
>+    device->properties.properties = NULL;
>+
>     /* Now free all handlers */
>     curr_handler = device->properties.handlers;
>     while(curr_handler)
>-- 
>1.6.5.2
>

Actions: View | Splinter Review

Attachments on bug 25374: 31696

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.