Attachment 31807 Details for Bug 25477 – Remove the DRM_ERROR

[patch] Remove the DRM_ERROR

0001-drm-i915-Drop-a-common-DRM_ERROR.patch (text/plain), 1.13 KB, created by Chris Wilson on 2009-12-07 03:35:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2009-12-07 03:35:22 UTC

Size: 1.13 KB

patch

obsolete

>From 5f55ea21ab264b6cffe81bd25e4a3404852202e6 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Mon, 7 Dec 2009 11:31:30 +0000
>Subject: [PATCH] drm/i915: Drop a common DRM_ERROR()
>
>These are handled by the error return being propagated to user-space and
>do not any add any information to the original error, so are useless.
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/i915_gem.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>index 846f050..a818969 100644
>--- a/drivers/gpu/drm/i915/i915_gem.c
>+++ b/drivers/gpu/drm/i915/i915_gem.c
>@@ -3667,14 +3667,12 @@ i915_gem_execbuffer(struct drm_device *dev, void *data,
> 	i915_verify_inactive(dev, __FILE__, __LINE__);
> 
> 	if (atomic_read(&dev_priv->mm.wedged)) {
>-		DRM_ERROR("Execbuf while wedged\n");
> 		mutex_unlock(&dev->struct_mutex);
> 		ret = -EIO;
> 		goto pre_mutex_err;
> 	}
> 
> 	if (dev_priv->mm.suspended) {
>-		DRM_ERROR("Execbuf while VT-switched.\n");
> 		mutex_unlock(&dev->struct_mutex);
> 		ret = -EBUSY;
> 		goto pre_mutex_err;
>-- 
>1.6.5.4
>

Actions: View | Splinter Review

Attachments on bug 25477: 31807

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.