Attachment 31880 Details for Bug 25536 – Probable fix

[patch] Probable fix

0001-EXA-mixed-Don-t-consider-devKind-for-detecting-dimen.patch (text/plain), 1.16 KB, created by Michel Dänzer on 2009-12-09 04:51:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Dänzer

Created: 2009-12-09 04:51:51 UTC

Size: 1.16 KB

patch

obsolete

>From a15d0d7c858ff6b9442ce25966c43c5f23e73169 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Michel=20D=C3=A4nzer?= <daenzer@vmware.com>
>Date: Wed, 9 Dec 2009 12:00:39 +0100
>Subject: [PATCH] EXA/mixed: Don't consider devKind for detecting dimension change.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>There should be no reason for the pitch to actually change when none of the
>other dimensions do, and this could lead to incorrectly freeing the system
>memory copy when allocating a GPU copy, resulting in loss of valid pixmap
>contents.
>
>Signed-off-by: Michel DÃ¤nzer <daenzer@vmware.com>
>---
> exa/exa_mixed.c |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/exa/exa_mixed.c b/exa/exa_mixed.c
>index 0fb644b..155ed47 100644
>--- a/exa/exa_mixed.c
>+++ b/exa/exa_mixed.c
>@@ -155,7 +155,6 @@ exaModifyPixmapHeader_mixed(PixmapPtr pPixmap, int width, int height, int depth,
> 
>     if (width != pPixmap->drawable.width ||
> 	height != pPixmap->drawable.height ||
>-	devKind != pPixmap->devKind ||
> 	depth != pPixmap->drawable.depth ||
> 	bitsPerPixel != pPixmap->drawable.bitsPerPixel) {
> 	if (pExaPixmap->driverPriv) {
>-- 
>1.6.5.4
>

Actions: View | Splinter Review

Attachments on bug 25536: 31876 | 31877 | 31878 | 31879 | 31880

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.