Attachment 31948 Details for Bug 25538 – Don't unref result on established_session_recv()

[patch] Don't unref result on established_session_recv()

dont_unref_on_established_sesssion.patch (text/plain), 1.31 KB, created by Nicolas Dufresne on 2009-12-10 13:55:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicolas Dufresne

Created: 2009-12-10 13:55:10 UTC

Size: 1.31 KB

patch

obsolete

>commit ad74940243a72afcbd02f03e21842b7a34f5a5ae
>Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
>Date:   Thu Dec 10 16:49:37 2009 -0500
>
>    Don't unref result when establish_session completes
>    
>    The result is expected to be valid in wocky_connector_*_finish function.
>    Type checking was preventing most crash, but a missing ref leads to a
>    crash when connector was destroyed while connecting. See bugs.fd.o #25538
>    
>    Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
>
>diff --git a/wocky/wocky-connector.c b/wocky/wocky-connector.c
>index a863a45..6160fc6 100644
>--- a/wocky/wocky-connector.c
>+++ b/wocky/wocky-connector.c
>@@ -2444,7 +2444,6 @@ establish_session_recv_cb (GObject *source,
>       WockyXmppNode *node = NULL;
>       const char *tag = NULL;
>       WockyConnectorError code;
>-      GSimpleAsyncResult *tmp;
> 
>       case WOCKY_STANZA_SUB_TYPE_ERROR:
>         node = wocky_xmpp_node_get_child (reply->node, "error");
>@@ -2473,11 +2472,7 @@ establish_session_recv_cb (GObject *source,
>             xep77_begin (self);
>           }
>         else
>-          {
>-            tmp = priv->result;
>-            g_simple_async_result_complete (tmp);
>-            g_object_unref (tmp);
>-          }
>+            g_simple_async_result_complete (priv->result);
>         break;
> 
>       default:

Actions: View | Splinter Review

Attachments on bug 25538: 31883 | 31884 | 31891 | 31948 | 31991 | 31992

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.