Attachment 31971 Details for Bug 25427 – patch to revert above patch to fix regression

[patch] patch to revert above patch to fix regression

0002-fix-is_set-behaviour-regression.patch (text/plain), 1.06 KB, created by Martin Pitt on 2009-12-11 00:39:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Pitt

Created: 2009-12-11 00:39:01 UTC

Size: 1.06 KB

patch

obsolete

>From 2b4d38de42b56e449e41a59f514fd991f3c16b04 Mon Sep 17 00:00:00 2001
>From: Martin Pitt <martin.pitt@ubuntu.com>
>Date: Fri, 11 Dec 2009 09:33:41 +0100
>Subject: [PATCH 2/2] fix is_set() behaviour regression
>
>Commit f7df23f29 essentially reverted the implied default value of all
>variables, which e. g. always turned on debugging and completely broke suspend.
>So far the code has been written with the assumption that is_set() returns
>2 (and not 0) for undefined variables, so before the default value of variables
>can be true, the entire code would need to change first.
>
>Revert to the original behaviour now.
>
>http://bugs.freedesktop.org/show_bug.cgi?id=25427
>---
> pm/functions.in |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/pm/functions.in b/pm/functions.in
>index 4fb9d1f..c43de1d 100644
>--- a/pm/functions.in
>+++ b/pm/functions.in
>@@ -8,7 +8,7 @@
> is_set()
> {
>     case ${1-UNSET} in
>-	true|yes|TRUE|YES|on|ON|1|'') return 0;;
>+	true|yes|TRUE|YES|on|ON|1) return 0;;
> 	false|FALSE|no|NO|off|OFF|0|UNSET) return 1;;
> 	*) return 2;;
>     esac
>-- 
>1.6.5
>

Actions: View | Splinter Review

Attachments on bug 25427: 31971

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.