Attachment 32039 Details for Bug 25620 – Patch to fix the problem

[patch] Patch to fix the problem

0001-Make-sure-to-create-the-_generated-directory-before-.patch (text/plain), 1.46 KB, created by Diego Elio Pettenò on 2009-12-13 06:03:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Diego Elio Pettenò

Created: 2009-12-13 06:03:04 UTC

Size: 1.46 KB

patch

obsolete

>From e5021f5ff473037fcb78419e708410582c7dc680 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Diego=20Elio=20'Flameeyes'=20Petten=C3=B2?= <flameeyes@gmail.com>
>Date: Sun, 13 Dec 2009 14:57:37 +0100
>Subject: [PATCH] Make sure to create the _generated directory before creating __init__.py.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>When building in parallel, the xsltproc processes and the single echo
>process will be most likely simultaneously (for an high enough amount of
>jobs).
>
>The echo is straightforward, while the XSLT processing takes time, this
>means that it'd be the first one to complete and thus create its output;
>unfortunately while xsltproc does create the structure of directories if it
>doesn't find it already, shell output redirection won't, so you have to
>create it beforehand for the echo to complete properly.
>
>An easy way to test this before was to simply request
>âmake _generated/__init__.pyâ on a pristine source directory.
>---
> src/Makefile.am |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/src/Makefile.am b/src/Makefile.am
>index fb15ff7..863c167 100644
>--- a/src/Makefile.am
>+++ b/src/Makefile.am
>@@ -55,6 +55,7 @@ _generated/errors.py: $(tools_dir)/python-errors-generator.xsl $(wildcard $(spec
> 	    $(spec_dir)/all.xml
> 
> _generated/__init__.py:
>+	$(mkdir_p) $(dir $@)
> 	echo "# Placeholder for package" > $@
> 
> _generated/%.py: $(tools_dir)/spec-to-python.xsl $(spec_dir)/%.xml
>-- 
>1.6.5.6
>

Actions: View | Splinter Review

Attachments on bug 25620: 32039

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.