Attachment 32246 Details for Bug 25492 – patch to fix the test

[patch] patch to fix the test

0001-test-xi2-fix-maximum-max_keycode-bug-25492.patch (text/plain), 1.04 KB, created by Julien Cristau on 2009-12-22 08:18:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julien Cristau

Created: 2009-12-22 08:18:43 UTC

Size: 1.04 KB

patch

obsolete

>From 84e4b9fd66bdeeab48af402680514a8390a0e289 Mon Sep 17 00:00:00 2001
>From: Julien Cristau <jcristau@debian.org>
>Date: Tue, 22 Dec 2009 17:14:09 +0100
>Subject: [PATCH] test/xi2: fix maximum max_keycode (bug#25492)
>
>The number of keycodes needs to be lower than 0xFFFD so that the length
>field of xXIKeyInfo doesn't overflow.
>
>Signed-off-by: Julien Cristau <jcristau@debian.org>
>---
> test/xi2/protocol-eventconvert.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/test/xi2/protocol-eventconvert.c b/test/xi2/protocol-eventconvert.c
>index 65ddec5..66686cb 100644
>--- a/test/xi2/protocol-eventconvert.c
>+++ b/test/xi2/protocol-eventconvert.c
>@@ -834,7 +834,7 @@ static void test_convert_XIDeviceChangedEvent(void)
>     in.keys.max_keycode = 1 << 8;
>     test_XIDeviceChangedEvent(&in);
> 
>-    in.keys.max_keycode = 0xFFFD; /* highest range, above that the length
>+    in.keys.max_keycode = 0xFFFC; /* highest range, above that the length
>                                      field gives up */
>     test_XIDeviceChangedEvent(&in);
> 
>-- 
>1.6.5
>

Actions: View | Splinter Review

Attachments on bug 25492: 32246

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.