Attachment 32596 Details for Bug 24589 – xdm-Call-openlog-3-early.patch

[patch] xdm-Call-openlog-3-early.patch

xdm-Call-openlog-3-early.patch (text/plain), 2.50 KB, created by Dmitry V. Levin on 2010-01-12 09:49:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dmitry V. Levin

Created: 2010-01-12 09:49:33 UTC

Size: 2.50 KB

patch

obsolete

>From 4330b458897a692e09bc106555e3c1b165b31068 Mon Sep 17 00:00:00 2001
>From: Dmitry V. Levin <ldv@altlinux.org>
>Date: Mon, 11 Jan 2010 23:09:47 +0000
>Subject: [PATCH] Call openlog(3) early
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Before this change, openlog(3) used to be called by greeter which could
>be built as a dynamically loadable plugin.  In the latter case, the
>ident string passed to openlog(3) resides in a dynamically mapped
>memory region that is unmapped later when the plugin is unloaded.
>This can cause fatal problems in some environments.  For example, in
>any GNU/Linux system with PAM support enabled an implicit syslog(3)
>call made by a PAM module after plugin unload causes attempt to access
>already unmapped memory, followed by instant crash.
>
>It is a common practice to call openlog(3) before the first syslog(3)
>call, including implicit calls that could be made e.g. by PAM.
>Also, openlog(3) LOG_ODELAY flag is redundant.
>
>Fixes ALT Linux Bug #22362 <https://bugzilla.altlinux.org/show_bug.cgi?id=22362>
>Fixes FreeDesktop Bug #24589 <https://bugs.freedesktop.org/show_bug.cgi?id=24589>
>
>Reported-by: Martin MokrejÅ¡ <mmokrejs@ribosome.natur.cuni.cz>
>Reported-by: Denis Kirienko <dk@altlinux.org>
>Patch-by: Oleg Zenin <tt@compas.ihep.su>
>Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
>---
> dm.c            |   13 +++++++++++++
> greeter/greet.c |    3 ---
> 2 files changed, 13 insertions(+), 3 deletions(-)
>
>diff --git a/dm.c b/dm.c
>index abe4453..8186424 100644
>--- a/dm.c
>+++ b/dm.c
>@@ -75,6 +75,16 @@ from The Open Group.
> # endif
> #endif
> 
>+#if defined(HAVE_OPENLOG) && defined(HAVE_SYSLOG_H)
>+# define USE_SYSLOG
>+# include <syslog.h>
>+# ifndef LOG_AUTHPRIV
>+#  define LOG_AUTHPRIV LOG_AUTH
>+# endif
>+# ifndef LOG_PID
>+#  define LOG_PID 0
>+# endif
>+#endif
> 
> #if defined(SVR4) && !defined(sun)
> extern FILE    *fdopen();
>@@ -749,6 +759,9 @@ StartDisplay (struct display *d)
> 	    CleanUpChild ();
> 	    (void) Signal (SIGPIPE, SIG_IGN);
> 	}
>+#ifdef USE_SYSLOG
>+	openlog("xdm", LOG_PID, LOG_AUTHPRIV);
>+#endif
> 	LoadSessionResources (d);
> 	SetAuthorization (d);
> 	if (!WaitForServer (d))
>diff --git a/greeter/greet.c b/greeter/greet.c
>index 17d21c8..61c7a52 100644
>--- a/greeter/greet.c
>+++ b/greeter/greet.c
>@@ -489,9 +489,6 @@ greet_user_rtn GreetUser(
> 	LogError ("Cannot reopen display %s for greet window\n", d->name);
> 	exit (RESERVER_DISPLAY);
>     }
>-#ifdef USE_SYSLOG
>-    openlog("xdm", LOG_ODELAY|LOG_PID, LOG_AUTHPRIV);
>-#endif
> 
>     for (;;) {
> #ifdef USE_PAM
>-- 
>1.6.5.7
>

Actions: View | Splinter Review

Attachments on bug 24589: 31179 | 31180 | 32596 | 32712

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.