Attachment 32892 Details for Bug 24152 – fix format security error

[patch] fix format security error

ConsoleKit-0.4.1-format_not_a_string_literal_and_no_format_arguments.patch (text/plain), 4.80 KB, created by Frederic Crozat on 2010-01-29 02:07:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frederic Crozat

Created: 2010-01-29 02:07:49 UTC

Size: 4.80 KB

patch

obsolete

>From 416eaa1543cea6ab8a0d13426add2f37ddc81cd9 Mon Sep 17 00:00:00 2001
>From: unknown author <cooker@mandrivalinux.org>
>Date: Wed, 8 Apr 2009 12:49:50 +0000
>Subject: [PATCH] format not a string literal and no format arguments
>
>---
> src/ck-log-event.c |   16 ++++++++--------
> src/main.c         |    2 +-
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/src/ck-log-event.c b/src/ck-log-event.c
>index 66f439c..5cc88ce 100644
>--- a/src/ck-log-event.c
>+++ b/src/ck-log-event.c
>@@ -721,7 +721,7 @@ parse_log_for_seat_added (const GString *str,
>         error = NULL;
>         re = g_regex_new ("seat-id='(?P<seatid>[a-zA-Z0-9/]+)' seat-kind=(?P<sessionid>[0-9]*)", 0, 0, &error);
>         if (re == NULL) {
>-                g_warning (error->message);
>+                g_warning ("%s", error->message);
>                 goto out;
>         }
> 
>@@ -781,7 +781,7 @@ parse_log_for_seat_removed (const GString *str,
>         error = NULL;
>         re = g_regex_new ("seat-id='(?P<seatid>[a-zA-Z0-9/]+)' seat-kind=(?P<sessionid>[0-9]*)", 0, 0, &error);
>         if (re == NULL) {
>-                g_warning (error->message);
>+                g_warning ("%s", error->message);
>                 goto out;
>         }
> 
>@@ -887,7 +887,7 @@ parse_log_for_system_start (const GString *str,
>         error = NULL;
>         re = g_regex_new ("(kernel-release='(?P<release>[^']+)')?[ ]?(boot-arguments='(?P<arguments>.*)')?", 0, 0, &error);
>         if (re == NULL) {
>-                g_warning (error->message);
>+                g_warning ("%s", error->message);
>                 goto out;
>         }
> 
>@@ -941,7 +941,7 @@ parse_log_for_seat_session_added (const GString *str,
>         error = NULL;
>         re = g_regex_new ("seat-id='(?P<seatid>[a-zA-Z0-9/]+)' session-id='(?P<sessionid>[a-zA-Z0-9/]+)' session-type='(?P<sessiontype>[a-zA-Z0-9 ]*)' session-x11-display='(?P<sessionx11display>[0-9a-zA-Z.:]*)' session-x11-display-device='(?P<sessionx11displaydevice>[^']*)' session-display-device='(?P<sessiondisplaydevice>[^']*)' session-remote-host-name='(?P<sessionremovehostname>[^']*)' session-is-local=(?P<sessionislocal>[a-zA-Z]*) session-unix-user=(?P<sessionunixuser>[0-9]*) session-creation-time='(?P<sessioncreationtime>[^']*)'", 0, 0, &error);
>         if (re == NULL) {
>-                g_warning (error->message);
>+                g_warning ("%s", error->message);
>                 goto out;
>         }
> 
>@@ -1016,7 +1016,7 @@ parse_log_for_seat_session_removed (const GString *str,
>         error = NULL;
>         re = g_regex_new ("seat-id='(?P<seatid>[a-zA-Z0-9/]+)' session-id='(?P<sessionid>[a-zA-Z0-9/]+)' session-type='(?P<sessiontype>[a-zA-Z0-9 ]*)' session-x11-display='(?P<sessionx11display>[0-9a-zA-Z.:]*)' session-x11-display-device='(?P<sessionx11displaydevice>[^']*)' session-display-device='(?P<sessiondisplaydevice>[^']*)' session-remote-host-name='(?P<sessionremovehostname>[^']*)' session-is-local=(?P<sessionislocal>[a-zA-Z]*) session-unix-user=(?P<sessionunixuser>[0-9]*) session-creation-time='(?P<sessioncreationtime>[^']*)'", 0, 0, &error);
>         if (re == NULL) {
>-                g_warning (error->message);
>+                g_warning ("%s", error->message);
>                 goto out;
>         }
> 
>@@ -1090,7 +1090,7 @@ parse_log_for_seat_active_session_changed (const GString *str,
>         error = NULL;
>         re = g_regex_new ("seat-id='(?P<seatid>[a-zA-Z0-9/]+)' session-id='(?P<sessionid>[a-zA-Z0-9/]*)'", 0, 0, &error);
>         if (re == NULL) {
>-                g_warning (error->message);
>+                g_warning ("%s", error->message);
>                 goto out;
>         }
> 
>@@ -1142,7 +1142,7 @@ parse_log_for_seat_device_added (const GString *str,
>         error = NULL;
>         re = g_regex_new ("seat-id='(?P<seatid>[a-zA-Z0-9/]+)' device-id='(?P<deviceid>[^']+)' device-type='(?P<devicetype>[^']+)'", 0, 0, &error);
>         if (re == NULL) {
>-                g_warning (error->message);
>+                g_warning ("%s", error->message);
>                 goto out;
>         }
> 
>@@ -1195,7 +1195,7 @@ parse_log_for_seat_device_removed (const GString *str,
>         error = NULL;
>         re = g_regex_new ("seat-id='(?P<seatid>[a-zA-Z0-9/]+)' device-id='(?P<deviceid>[^']+)' device-type='(?P<devicetype>[^']+)'", 0, 0, &error);
>         if (re == NULL) {
>-                g_warning (error->message);
>+                g_warning ("%s", error->message);
>                 goto out;
>         }
> 
>diff --git a/src/main.c b/src/main.c
>index 809c6d6..3722dc4 100644
>--- a/src/main.c
>+++ b/src/main.c
>@@ -283,7 +283,7 @@ main (int    argc,
>         res = g_option_context_parse (context, &argc, &argv, &error);
>         g_option_context_free (context);
>         if (! res) {
>-                g_warning (error->message);
>+                g_warning ("%s", error->message);
>                 g_error_free (error);
>                 goto out;
>         }
>-- 
>1.6.4.4
>

Actions: View | Splinter Review

Attachments on bug 24152: 32892

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.