Attachment 33283 Details for Bug 26559 – fix a bunch of errors, detected by cppcheck

[patch] fix a bunch of errors, detected by cppcheck

cppcheck_fixes.patch (text/plain), 1.51 KB, created by ettlmartin on 2010-02-13 14:50:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ettlmartin

Created: 2010-02-13 14:50:53 UTC

Size: 1.51 KB

patch

obsolete

>diff --git a/progs/fp/fp-tri.c b/progs/fp/fp-tri.c
>index 70676d4..e45a799 100644
>--- a/progs/fp/fp-tri.c
>+++ b/progs/fp/fp-tri.c
>@@ -188,6 +188,7 @@ static void Init( void )
>    }
> 
>    glClearColor(.1, .3, .5, 0);
>+   fclose(f);
> }
> 
> static void Reshape(int width, int height)
>diff --git a/progs/objviewer/glm.c b/progs/objviewer/glm.c
>index 7f36cdf..7c964e4 100644
>--- a/progs/objviewer/glm.c
>+++ b/progs/objviewer/glm.c
>@@ -421,6 +421,7 @@ _glmReadMTL(GLMmodel* model, char* name)
>       break;
>     }
>   }
>+  fclose(file);
> }
> 
> 
>@@ -475,6 +476,7 @@ _glmWriteMTL(GLMmodel* model, char* modelpath, char* mtllibname)
>     fprintf(file, "Ns %f\n", material->shininess);
>     fprintf(file, "\n");
>   }
>+  fclose(file);
> }
> 
> 
>diff --git a/src/glu/mesa/mipmap.c b/src/glu/mesa/mipmap.c
>index d85ce9b..cb871be 100644
>--- a/src/glu/mesa/mipmap.c
>+++ b/src/glu/mesa/mipmap.c
>@@ -287,7 +287,11 @@ gluScaleImage(GLenum format,
>       }
>       break;
>    default:
>+    {
>+	  free(tempin);
>+	  free(tempout);
>       return GLU_INVALID_ENUM;
>+    }
>    }
> 
> 
>@@ -670,6 +674,7 @@ gluBuild1DMipmaps(GLenum target, GLint components,
> 	 break;
>       default:
> 	 /* Not implemented */
>+	 free(texture);
> 	 return GLU_ERROR;
>       }
>    }
>diff --git a/src/glu/mini/mipmap.c b/src/glu/mini/mipmap.c
>index a655d21..d7d64d0 100644
>--- a/src/glu/mini/mipmap.c
>+++ b/src/glu/mini/mipmap.c
>@@ -287,7 +287,11 @@ gluScaleImage(GLenum format,
>       }
>       break;
>    default:
>+    {
>+	  free(tempin);
>+	  free(tempout);
>       return GLU_INVALID_ENUM;
>+	}
>    }
> 
>

Actions: View | Splinter Review

Attachments on bug 26559: 33283

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.