Attachment 33369 Details for Bug 26583 – Move _mcd_dispatcher_add_connection to an earlier stage.

[patch] Move _mcd_dispatcher_add_connection to an earlier stage.

Move-mcddispatcheraddconnection-to-an-earlier-stag.patch (text/plain), 1.53 KB, created by Eitan Isaacson on 2010-02-17 13:54:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Eitan Isaacson

Created: 2010-02-17 13:54:09 UTC

Size: 1.53 KB

patch

obsolete

>From 651fe66694a3265cd8c64312b2e0959690e4972a Mon Sep 17 00:00:00 2001
>From: Eitan Isaacson <eitan@monotonous.org>
>Date: Wed, 17 Feb 2010 11:59:34 -0800
>Subject: [PATCH] Move _mcd_dispatcher_add_connection to an earlier stage.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=26583
>---
> src/mcd-connection.c |   10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
>diff --git a/src/mcd-connection.c b/src/mcd-connection.c
>index 72d2bd3..41c78a7 100644
>--- a/src/mcd-connection.c
>+++ b/src/mcd-connection.c
>@@ -1534,6 +1534,7 @@ on_connection_ready (TpConnection *tp_conn, const GError *error,
>     if (priv->has_alias_if)
> 	_mcd_connection_setup_alias (connection);
> 
>+    if (!priv->dispatching_started)
>     _mcd_dispatcher_add_connection (priv->dispatcher, connection);
> 
>     g_signal_emit (connection, signals[READY], 0);
>@@ -1707,6 +1708,15 @@ mcd_connection_early_get_interfaces_cb (TpConnection *tp_conn,
>                  * we can't usefully pre-load capabilities - we'll be told
>                  * the real capabilities as soon as it has worked them out */
>             }
>+            else if (q == TP_IFACE_QUARK_CONNECTION_INTERFACE_REQUESTS)
>+            {
>+              /* If we have the Requests iface, we could start dispatching
>+               * before the connection is in CONNECTED state */
>+              tp_proxy_add_interface_by_id ((TpProxy *) tp_conn, q);
>+              self->priv->has_requests_if = TRUE;
>+
>+              _mcd_dispatcher_add_connection (self->priv->dispatcher, self);
>+            }
>         }
>     }
> 
>-- 
>1.7.0

Actions: View | Splinter Review

Attachments on bug 26583: 33366 | 33369

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.