Attachment 33570 Details for Bug 26758 – Patch as described

[patch] Patch as described

0001-language-bindings-guide-clarify-mapping-for-cairo_pa.patch (text/plain), 1.56 KB, created by Owen Taylor on 2010-02-25 12:25:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Taylor

Created: 2010-02-25 12:25:07 UTC

Size: 1.56 KB

patch

obsolete

>From 71f2f9168f38b30c6d8e8988e1cbc35b85364af0 Mon Sep 17 00:00:00 2001
>From: Owen W. Taylor <otaylor@fishsoup.net>
>Date: Thu, 25 Feb 2010 15:18:22 -0500
>Subject: [PATCH] language bindings guide: clarify mapping for cairo_pattern_create_rgb[a]
>
>Clarify that cairo_pattern_create_rgb() and cairo_pattern_create_rgba()
>should be be overloaded as a single constructor for SolidPattern, but
>instead should be static methods.
>---
> doc/public/language-bindings.xml |    9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/doc/public/language-bindings.xml b/doc/public/language-bindings.xml
>index 8d98b56..f405fda 100644
>--- a/doc/public/language-bindings.xml
>+++ b/doc/public/language-bindings.xml
>@@ -506,8 +506,13 @@ CAIRO_STATUS_WRITE_ERROR
>       linkend="cairo-pattern-t"><type>cairo_pattern_t</type></link>
>       in C, but in an object oriented language, there should instead
>       be a hierarchy of types. (The functions that should map to
>-      constructors for the various types are listed after the type,
>-      methods on that type are listed below)
>+      constructors or static methods for the various types are listed
>+      after the type, methods on that type are listed below. Note that
>+      cairo_pattern_create_rgb() and cairo_pattern_create_rgba()
>+      should not be overloaded with each other as a SolidPattern()
>+      constructor, but should appear as static methods instead.  This
>+      is to maintain code clarity by making it clear how the arguments
>+      relate to color components.)
>     </para>
>     <programlisting>
> cairo_pattern_t
>-- 
>1.6.6
>

Actions: View | Splinter Review

Attachments on bug 26758: 33570

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.