Attachment 33677 Details for Bug 26832 – proposed fix

[patch] proposed fix

0001-glx-remove-unused-variable-data-from-CreateData-in-g.patch (text/plain), 1.28 KB, created by Magnus Kessler on 2010-03-01 22:50:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Kessler

Created: 2010-03-01 22:50:14 UTC

Size: 1.28 KB

patch

obsolete

>From 3070fc1a4e89489e6181b5133ab8b6bfd01e4595 Mon Sep 17 00:00:00 2001
>From: Magnus Kessler <Magnus.Kessler@gmx.net>
>Date: Tue, 2 Mar 2010 06:42:00 +0000
>Subject: [PATCH] glx: remove unused variable "data" from CreateData in glx_puffer.c
>
>Fixes http://bugs.freedesktop.org/show_bug.cgi?id=26832
>---
> src/glx/glx_pbuffer.c |    5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
>diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c
>index f635138..4613477 100644
>--- a/src/glx/glx_pbuffer.c
>+++ b/src/glx/glx_pbuffer.c
>@@ -353,7 +353,6 @@ CreateDrawable(Display * dpy, const __GLcontextModes * fbconfig,
>                Drawable drawable, const int *attrib_list, CARD8 glxCode)
> {
>    xGLXCreateWindowReq *req;
>-   CARD32 *data;
>    unsigned int i;
>    CARD8 opcode;
> 
>@@ -369,7 +368,6 @@ CreateDrawable(Display * dpy, const __GLcontextModes * fbconfig,
> 
>    LockDisplay(dpy);
>    GetReqExtra(GLXCreateWindow, 8 * i, req);
>-   data = (CARD32 *) (req + 1);
> 
>    req->reqType = opcode;
>    req->glxCode = glxCode;
>@@ -379,9 +377,6 @@ CreateDrawable(Display * dpy, const __GLcontextModes * fbconfig,
>    req->glxwindow = (GLXWindow) XAllocID(dpy);
>    req->numAttribs = (CARD32) i;
> 
>-   assert(attrib_list);
>-   memcpy(data, attrib_list, 8 * i);
>-
>    UnlockDisplay(dpy);
>    SyncHandle();
> 
>-- 
>1.7.0
>

Actions: View | Splinter Review

Attachments on bug 26832: 33677

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.