Attachment 33960 Details for Bug 27008 – possible fix

[patch] possible fix

0001-drm-radeon-kms-rs4xx-make-sure-crtcs-are-enabled-wh.patch (text/plain), 1.59 KB, created by Alex Deucher on 2010-03-11 07:42:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2010-03-11 07:42:37 UTC

Size: 1.59 KB

patch

obsolete

>From 0be75bd324cea1eb577cf4bdebfb59af217876cf Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Thu, 11 Mar 2010 10:38:07 -0500
>Subject: [PATCH] drm/radeon/kms/rs4xx: make sure crtcs are enabled when setting timing
>
>based on ddx patch from Matthias Hopf.
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>---
> drivers/gpu/drm/radeon/radeon_legacy_crtc.c |    8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_legacy_crtc.c b/drivers/gpu/drm/radeon/radeon_legacy_crtc.c
>index df23d6a..88865e3 100644
>--- a/drivers/gpu/drm/radeon/radeon_legacy_crtc.c
>+++ b/drivers/gpu/drm/radeon/radeon_legacy_crtc.c
>@@ -603,6 +603,10 @@ static bool radeon_set_crtc_timing(struct drm_crtc *crtc, struct drm_display_mod
> 				      ? RADEON_CRTC2_INTERLACE_EN
> 				      : 0));
> 
>+		/* rs4xx chips seem to like to have the crtc enabled when the timing is set */
>+		if ((rdev->family == CHIP_RS400) || (rdev->family == CHIP_RS480))
>+			crtc2_gen_cntl |= RADEON_CRTC2_EN;
>+
> 		disp2_merge_cntl = RREG32(RADEON_DISP2_MERGE_CNTL);
> 		disp2_merge_cntl &= ~RADEON_DISP2_RGB_OFFSET_EN;
> 
>@@ -630,6 +634,10 @@ static bool radeon_set_crtc_timing(struct drm_crtc *crtc, struct drm_display_mod
> 				    ? RADEON_CRTC_INTERLACE_EN
> 				    : 0));
> 
>+		/* rs4xx chips seem to like to have the crtc enabled when the timing is set */
>+		if ((rdev->family == CHIP_RS400) || (rdev->family == CHIP_RS480))
>+			crtc_gen_cntl |= RADEON_CRTC_EN;
>+
> 		crtc_ext_cntl = RREG32(RADEON_CRTC_EXT_CNTL);
> 		crtc_ext_cntl |= (RADEON_XCRT_CNT_EN |
> 				  RADEON_CRTC_VSYNC_DIS |
>-- 
>1.5.6.3
>

Actions: View | Splinter Review

Attachments on bug 27008: 33934 | 33960 | 35804 | 35805 | 35871 | 35873 | 35891 | 35892 | 35893

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.