Attachment 34125 Details for Bug 27112 – [bus] Don't send an reply for driver messages if one isn't requested

[patch] [bus] Don't send an reply for driver messages if one isn't requested

0001-bus-Don-t-send-an-reply-for-driver-messages-if-one-i.patch (text/plain), 1014 bytes, created by Colin Walters on 2010-03-16 13:36:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Walters

Created: 2010-03-16 13:36:06 UTC

Size: 1014 bytes

patch

obsolete

>From ff1d761ba163408574c0565ff2560846d9805bfe Mon Sep 17 00:00:00 2001
>From: Colin Walters <walters@verbum.org>
>Date: Tue, 16 Mar 2010 13:20:36 -0400
>Subject: [PATCH] [bus] Don't send an reply for driver messages if one isn't requested
>
>Basically honor the no_reply flag; a binding is likely to want to
>set this so it doesn't have to process extra traffic for match
>rules.
>---
> bus/driver.c |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
>diff --git a/bus/driver.c b/bus/driver.c
>index 4a6a324..5e8a7a2 100644
>--- a/bus/driver.c
>+++ b/bus/driver.c
>@@ -32,6 +32,7 @@
> #include "utils.h"
> #include <dbus/dbus-string.h>
> #include <dbus/dbus-internals.h>
>+#include <dbus/dbus-message.h>
> #include <dbus/dbus-marshal-recursive.h>
> #include <string.h>
> 
>@@ -791,6 +792,9 @@ send_ack_reply (DBusConnection *connection,
> {
>   DBusMessage *reply;
> 
>+  if (dbus_message_get_no_reply (message))
>+    return TRUE;
>+
>   reply = dbus_message_new_method_return (message);
>   if (reply == NULL)
>     {
>-- 
>1.6.6.1
>

Actions: View | Splinter Review

Attachments on bug 27112: 34125

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.