Attachment 34229 Details for Bug 26302 – don't print pointless errors.

[patch] don't print pointless errors.

0002-drm-radeon-kms-don-t-print-error-on-ERESTARTSYS.patch (text/plain), 1.04 KB, created by Dave Airlie on 2010-03-18 17:39:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Airlie

Created: 2010-03-18 17:39:19 UTC

Size: 1.04 KB

patch

obsolete

>From fb01dcec1de69e58b39e4da14019aa77ff7b85ef Mon Sep 17 00:00:00 2001
>From: Dave Airlie <airlied@redhat.com>
>Date: Fri, 19 Mar 2010 10:33:44 +1000
>Subject: [PATCH 2/2] drm/radeon/kms: don't print error on -ERESTARTSYS.
>
>We can get this if the user moves the mouse when we are waiting to move
>some stuff around in the validate. Don't fail.
>
>Signed-off-by: Dave Airlie <airlied@redhat.com>
>---
> drivers/gpu/drm/radeon/radeon_cs.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
>index 8d99f70..3346d9e 100644
>--- a/drivers/gpu/drm/radeon/radeon_cs.c
>+++ b/drivers/gpu/drm/radeon/radeon_cs.c
>@@ -239,7 +239,8 @@ int radeon_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
> 	}
> 	r = radeon_cs_parser_relocs(&parser);
> 	if (r) {
>-		DRM_ERROR("Failed to parse relocation !\n");
>+		if (r != -ERESTARTSYS)
>+			DRM_ERROR("Failed to parse relocation %d!\n", r);
> 		radeon_cs_parser_fini(&parser, r);
> 		mutex_unlock(&rdev->cs_mutex);
> 		return r;
>-- 
>1.6.6.1
>

Actions: View | Splinter Review

Attachments on bug 26302: 32876 | 32877 | 32878 | 33219 | 33220 | 33665 | 34228 | 34229

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.