Attachment 34322 Details for Bug 27244 – Fix error_to_string() crash

[patch] Fix error_to_string() crash

0011-Fix-error_to_string-crash.patch (text/plain), 983 bytes, created by Ole André Vadla Ravnås on 2010-03-22 08:47:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ole André Vadla Ravnås

Created: 2010-03-22 08:47:25 UTC

Size: 983 bytes

patch

obsolete

>From 7abdeb3bcf104dc5be12626be4797d1a569a6350 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ole=20Andr=C3=A9=20Vadla=20Ravn=C3=A5s?= <ole.andre.ravnas@tandberg.com>
>Date: Mon, 22 Mar 2010 16:28:33 +0100
>Subject: [PATCH 11/12] Fix error_to_string() crash
>
>Declaring the static ssl_error array as const means that it may be read-
>only at runtime, which is not what you want in this case.
>---
> wocky/wocky-openssl.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/wocky/wocky-openssl.c b/wocky/wocky-openssl.c
>index c29d9db..a7ba51a 100644
>--- a/wocky/wocky-openssl.c
>+++ b/wocky/wocky-openssl.c
>@@ -242,7 +242,7 @@ wocky_tls_error_quark (void)
>  * not actually guaranteed anywhere so we have to check for it here:         */
> static const gchar *error_to_string (long error)
> {
>-  static const gchar ssl_error[256];
>+  static gchar ssl_error[256];
>   int e;
>   int x;
>   /* SSL_ERROR_NONE from ERR_get_error means we have emptied the stack, *
>-- 
>1.6.4.msysgit.0
>

Actions: View | Splinter Review

Attachments on bug 27244: 34312 | 34313 | 34314 | 34315 | 34316 | 34317 | 34318 | 34319 | 34320 | 34321 | 34322

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.