Attachment 34409 Details for Bug 26810 – Remove false reduction of a composite to a blit

[patch] Remove false reduction of a composite to a blit

0002-uxa-Only-reduce-a-composite-to-a-BLT-if-it-is-wholly.patch (text/plain), 1.30 KB, created by Chris Wilson on 2010-03-24 08:25:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2010-03-24 08:25:23 UTC

Size: 1.30 KB

patch

obsolete

>From 14e0d3d3a42deac41aff72f8a6aa032ba55c54ea Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Wed, 24 Mar 2010 14:50:45 +0000
>Subject: [PATCH 2/3] uxa: Only reduce a composite to a BLT if it is wholly contained
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> uxa/uxa-render.c |   18 +++++++++++++++++-
> 1 files changed, 17 insertions(+), 1 deletions(-)
>
>diff --git a/uxa/uxa-render.c b/uxa/uxa-render.c
>index ca46a2a..bcfe20e 100644
>--- a/uxa/uxa-render.c
>+++ b/uxa/uxa-render.c
>@@ -977,6 +977,21 @@ compatible_formats (CARD8 op, PicturePtr dst, PicturePtr src)
> 	return 0;
> }
> 
>+static int
>+drawable_contains (DrawablePtr drawable, int x1, int y1, int x2, int y2)
>+{
>+	if (x1 < 0 || y1 < 0)
>+		return FALSE;
>+
>+	if (x2 > drawable->width)
>+		return FALSE;
>+
>+	if (y2 > drawable->height)
>+		return FALSE;
>+
>+	return TRUE;
>+}
>+
> void
> uxa_composite(CARD8 op,
> 	      PicturePtr pSrc,
>@@ -1026,7 +1041,8 @@ uxa_composite(CARD8 op,
> 								width, height);
> 				if (ret == 1)
> 					goto done;
>-			} else if (!pSrc->repeat && !pSrc->transform) {
>+			} else if (!pSrc->repeat && !pSrc->transform &&
>+				   drawable_contains(pSrc->pDrawable, xSrc, ySrc, xSrc + width, ySrc + height)) {
> 				xDst += pDst->pDrawable->x;
> 				yDst += pDst->pDrawable->y;
> 				xSrc += pSrc->pDrawable->x;
>-- 
>1.7.0.3
>

Actions: View | Splinter Review

Attachments on bug 26810: 34012 | 34409

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.