Attachment 35146 Details for Bug 27726 – The proposed solution

[patch] The proposed solution

0001-xfree86-Makefile-shouldn-t-rely-on-superuser-being-n.patch (text/plain), 1.07 KB, created by Michał Górny on 2010-04-18 11:20:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michał Górny

Created: 2010-04-18 11:20:47 UTC

Size: 1.07 KB

patch

obsolete

>From 71e77b9cbebfef0e37c4996967857e379f74d9a3 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= <gentoo@mgorny.alt.pl>
>Date: Sun, 18 Apr 2010 20:15:16 +0200
>Subject: [PATCH] xfree86: Makefile shouldn't rely on superuser being named 'root'
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Change the 'chown' statement in Makefile.am to use the numeric UID
>of superuser instead of relying on the name 'root'.
>
>Signed-off-by: MichaÅ GÃ³rny <gentoo@mgorny.alt.pl>
>
>https://bugs.freedesktop.org/show_bug.cgi?id=27726
>---
> hw/xfree86/Makefile.am |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am
>index 116113b..77cdc32 100644
>--- a/hw/xfree86/Makefile.am
>+++ b/hw/xfree86/Makefile.am
>@@ -104,7 +104,7 @@ install-data-local:
> install-exec-local: install-binPROGRAMS
> 	(cd $(DESTDIR)$(bindir) && rm -f X && ln -s Xorg X)
> if INSTALL_SETUID
>-	chown root $(DESTDIR)$(bindir)/Xorg
>+	chown 0 $(DESTDIR)$(bindir)/Xorg
> 	chmod u+s $(DESTDIR)$(bindir)/Xorg
> endif
> 
>-- 
>1.7.0.4
>

Actions: View | Splinter Review

Attachments on bug 27726: 35146

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.