Attachment 35668 Details for Bug 28079 – Remove the DRM_DEBUG, it's too dangerous

[patch] Remove the DRM_DEBUG, it's too dangerous

0001-drm-i915-Kill-dangerous-pending-flip-debugging.patch (text/plain), 1.74 KB, created by Chris Wilson on 2010-05-15 01:55:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2010-05-15 01:55:13 UTC

Size: 1.74 KB

patch

obsolete

>From ac3db7b27712e4f7bbacbe17f9c89b9a2f05f636 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Sat, 15 May 2010 09:48:19 +0100
>Subject: [PATCH] drm/i915: Kill dangerous pending-flip debugging
>
>We can, by virtue of a vblank interrupt firing in the middle of setting
>up the unpin work (i.e. after we set the unpin_work field and before we
>write to the ringbuffer) prior to receiving the pending flip
>notification. Therefore we can expect to hit intel_page_flip_finish()
>under normal circumstances without a pending flip and even without
>installing the pending_flip_obj. This is exacerbated by aperture
>thrashing whilst binding the framebuffer
>
>References:
>
>  Bug 28079 - "glresize" causes kernel panic in intel_finish_page_flip.
>  https://bugs.freedesktop.org/show_bug.cgi?id=28079
>
>Reported-by: Nick Bowler <nbowler@draconx.ca>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
>Cc: stable@kernel.org
>---
> drivers/gpu/drm/i915/intel_display.c |    6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index 77d8732..35937ce 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -4155,12 +4155,6 @@ void intel_finish_page_flip(struct drm_device *dev, int pipe)
> 	spin_lock_irqsave(&dev->event_lock, flags);
> 	work = intel_crtc->unpin_work;
> 	if (work == NULL || !work->pending) {
>-		if (work && !work->pending) {
>-			obj_priv = to_intel_bo(work->pending_flip_obj);
>-			DRM_DEBUG_DRIVER("flip finish: %p (%d) not pending?\n",
>-					 obj_priv,
>-					 atomic_read(&obj_priv->pending_flip));
>-		}
> 		spin_unlock_irqrestore(&dev->event_lock, flags);
> 		return;
> 	}
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 28079: 35603 | 35649 | 35653 | 35660 | 35668

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.