Attachment 36172 Details for Bug 27408 – Off-by-one drawrect fix.

[patch] Off-by-one drawrect fix.

0001-i915-Fix-off-by-one-for-drawing-rectangle.patch (text/plain), 1.52 KB, created by Chris Wilson on 2010-06-09 00:52:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2010-06-09 00:52:09 UTC

Size: 1.52 KB

patch

obsolete

>From add3260157368458501709d08a3f913ed448234f Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Sat, 5 Jun 2010 09:33:58 +0100
>Subject: [PATCH] i915: Fix off-by-one for drawing rectangle.
>
>The drawing rectangle is given in *inclusive* pixel values, so the range
>is only [0,2047]. Hence when rendering to a 2048 wide target, such as an
>extended desktop, we would issue an illegal instruction zeroing the draw
>area.
>
>Fixes:
>
>  Bug 27408: Primary and Secondary display blanks in extended
>             desktop mode with Compiz enabled
>  https://bugs.freedesktop.org/show_bug.cgi?id=27408
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> src/mesa/drivers/dri/i915/i915_vtbl.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/i915/i915_vtbl.c b/src/mesa/drivers/dri/i915/i915_vtbl.c
>index 974ab3e..b2f9b90 100644
>--- a/src/mesa/drivers/dri/i915/i915_vtbl.c
>+++ b/src/mesa/drivers/dri/i915/i915_vtbl.c
>@@ -627,8 +627,8 @@ i915_set_draw_region(struct intel_context *intel,
>    state->Buffer[I915_DESTREG_DRAWRECT2] = 0;
>    state->Buffer[I915_DESTREG_DRAWRECT3] = (draw_y << 16) | draw_x;
>    state->Buffer[I915_DESTREG_DRAWRECT4] =
>-      ((ctx->DrawBuffer->Width + draw_x) & 0xffff) |
>-      ((ctx->DrawBuffer->Height + draw_y) << 16);
>+      ((ctx->DrawBuffer->Width + draw_x - 1) & 0xffff) |
>+      ((ctx->DrawBuffer->Height + draw_y - 1) << 16);
>    state->Buffer[I915_DESTREG_DRAWRECT5] = (draw_y << 16) | draw_x;
> 
>    I915_STATECHANGE(i915, I915_UPLOAD_BUFFERS);
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 27408: 34591 | 34592 | 34593 | 34762 | 36172

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.