Attachment 3659 Details for Bug 4901 – patch to fix secondary color issue when lighting is disabled on radeon and r200

[patch] patch to fix secondary color issue when lighting is disabled on radeon and r200

radeon_seccolor.diff (text/plain), 1.34 KB, created by Roland Scheidegger on 2005-10-28 16:26:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Roland Scheidegger

Created: 2005-10-28 16:26:36 UTC

Size: 1.34 KB

patch

obsolete

>Index: r200/r200_tcl.c
>===================================================================
>RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/r200/r200_tcl.c,v
>retrieving revision 1.24
>diff -u -r1.24 r200_tcl.c
>--- r200/r200_tcl.c	18 Oct 2005 13:09:53 -0000	1.24
>+++ r200/r200_tcl.c	28 Oct 2005 23:20:12 -0000
>@@ -395,9 +395,10 @@
>     */
>    if (ctx->Light.Enabled) {
>       inputs |= VERT_BIT_NORMAL;
>-      if (ctx->_TriangleCaps & DD_SEPARATE_SPECULAR) {
>-	 inputs |= VERT_BIT_COLOR1;
>-      }
>+   }
>+
>+   if (ctx->_TriangleCaps & DD_SEPARATE_SPECULAR) {
>+      inputs |= VERT_BIT_COLOR1;
>    }
> 
>    if ( (ctx->Fog.FogCoordinateSource == GL_FOG_COORD) && ctx->Fog.Enabled ) {
>Index: radeon/radeon_tcl.c
>===================================================================
>RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/radeon/radeon_tcl.c,v
>retrieving revision 1.17
>diff -u -r1.17 radeon_tcl.c
>--- radeon/radeon_tcl.c	17 Oct 2005 00:54:12 -0000	1.17
>+++ radeon/radeon_tcl.c	28 Oct 2005 23:20:23 -0000
>@@ -391,9 +391,10 @@
>     */
>    if (ctx->Light.Enabled) {
>       inputs |= VERT_BIT_NORMAL;
>-      if (ctx->_TriangleCaps & DD_SEPARATE_SPECULAR) {
>-	 inputs |= VERT_BIT_COLOR1;
>-      }
>+   }
>+
>+   if (ctx->_TriangleCaps & DD_SEPARATE_SPECULAR) {
>+      inputs |= VERT_BIT_COLOR1;
>    }
> 
>    if ( (ctx->Fog.FogCoordinateSource == GL_FOG_COORD) && ctx->Fog.Enabled ) {

Actions: View | Splinter Review

Attachments on bug 4901: 3659

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.