Attachment 36657 Details for Bug 28639 – Removes an unnecessary call to dixSetPrivate

[patch] Removes an unnecessary call to dixSetPrivate

0001-miDbe-window-priv-priv-is-pre-allocated-no-need-to-u.patch (text/plain), 1.30 KB, created by Keith Packard on 2010-07-01 06:19:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Packard

Created: 2010-07-01 06:19:33 UTC

Size: 1.30 KB

patch

obsolete

>From 3b8d0cc975e9db43ae1a50dc0b4752d908aa242d Mon Sep 17 00:00:00 2001
>From: Keith Packard <keithp@keithp.com>
>Date: Thu, 1 Jul 2010 09:13:43 -0400
>Subject: [PATCH] miDbe window priv priv is pre-allocated, no need to use dixSetPrivate
>
>miDbeInit pre-allocates space in each DBE window private private for a
>MiDbeWindowPrivPrivRec. miDbeAllocBackBufferName used the
>pre-allocated space correctly (simply fetching it instead of
>allocating a new piece of memory). However, it then called
>dixSetPrivate anyways, which isn't necessary, and (in the new
>dixPrivate world) causes an assert failure.
>
>Signed-off-by: Keith Packard <keithp@keithp.com>
>---
> dbe/midbe.c |    6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
>diff --git a/dbe/midbe.c b/dbe/midbe.c
>index 954f46e..b43ac1b 100644
>--- a/dbe/midbe.c
>+++ b/dbe/midbe.c
>@@ -202,12 +202,6 @@ miDbeAllocBackBufferName(WindowPtr pWin, XID bufId, int swapAction)
>             return (rc == Success) ? BadAlloc : rc;
>         }
> 
>-
>-        /* Attach the priv priv to the priv. */
>-	dixSetPrivate(&pDbeWindowPriv->devPrivates, miDbeWindowPrivPrivKey,
>-		      pDbeWindowPrivPriv);
>-
>-
>         /* Clear the back buffer. */
>         pGC = GetScratchGC(pWin->drawable.depth, pWin->drawable.pScreen);
>         if ((*pDbeScreenPriv->SetupBackgroundPainter)(pWin, pGC))
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 28639: 36657

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.