Attachment 36844 Details for Bug 28410 – return the proper crtc_id

[patch] return the proper crtc_id

0001-drm-radeon-kms-fix-RADEON_INFO_CRTC_FROM_ID-info-ioc.patch (text/plain), 1.10 KB, created by Alex Deucher on 2010-07-07 13:01:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2010-07-07 13:01:59 UTC

Size: 1.10 KB

patch

obsolete

>From 1bec84980343495c2de69dba9f72e69ef1038e02 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Wed, 7 Jul 2010 15:58:59 -0400
>Subject: [PATCH] drm/radeon/kms: fix RADEON_INFO_CRTC_FROM_ID info ioctl
>
>Return the crtc_id, not the counter value.  They are not
>necessarily the same.
>
>Might fix:
>https://bugs.freedesktop.org/show_bug.cgi?id=28410
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>---
> drivers/gpu/drm/radeon/radeon_kms.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c
>index 9012e6f..8931c8e 100644
>--- a/drivers/gpu/drm/radeon/radeon_kms.c
>+++ b/drivers/gpu/drm/radeon/radeon_kms.c
>@@ -134,7 +134,8 @@ int radeon_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
> 		for (i = 0, found = 0; i < rdev->num_crtc; i++) {
> 			crtc = (struct drm_crtc *)minfo->crtcs[i];
> 			if (crtc && crtc->base.id == value) {
>-				value = i;
>+				struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc);
>+				value = radeon_crtc->crtc_id;
> 				found = 1;
> 				break;
> 			}
>-- 
>1.7.0.1
>

Actions: View | Splinter Review

Attachments on bug 28410: 36844 | 37036

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.