Attachment 37054 Details for Bug 29065 – hack to show the random freed values instead of crashing.

[patch] hack to show the random freed values instead of crashing.

ati_workaround_forvblankreceivedafterclientisfreed3.diff (text/plain), 1.79 KB, created by Alban Browaeys on 2010-07-14 13:55:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alban Browaeys

Created: 2010-07-14 13:55:49 UTC

Size: 1.79 KB

patch

obsolete

>diff --git a/src/radeon_dri2.c b/src/radeon_dri2.c
>index a0ed085..3781e16 100644
>--- a/src/radeon_dri2.c
>+++ b/src/radeon_dri2.c
>@@ -360,6 +360,41 @@ void radeon_dri2_frame_event_handler(unsigned int frame, unsigned int tv_sec,
>     BoxRec box;
>     RegionRec region;
> 
>+    if (event->client->index > MAXCLIENTS) {
>+        ErrorF("radeon_dri2_frame_event_handler: ERROR : discard event as client index %d is above max %u\n",event->client->index, MAXCLIENTS);
>+        free(event);
>+        return;
>+    }
>+    if (event->client->index < 0) {
>+        ErrorF("radeon_dri2_frame_event_handler: ERROR : discard event as client index %d is below 0\n",event->client->index);
>+        free(event);
>+        return;
>+    }
>+
>+    if (clients[event->client->index] == NULL) {
>+        ErrorF("radeon_dri2_frame_event_handler: ERROR : discard event as clients indexed client is NULL\n");
>+        free(event);
>+        return;
>+    }
>+
>+    if (clients[event->client->index]->errorValue == 0) {
>+        ErrorF("radeon_dri2_frame_event_handler: ERROR : discard event as clients indexed client ierrorValue is 0\n");
>+        free(event);
>+        return;
>+    }
>+
>+    if (clients[event->client->index]->errorValue != event->client->errorValue) {
>+        ErrorF("radeon_dri2_frame_event_handler: ERROR : discard event as client error value do not match : clients %u event %u\n", clients[event->client->index]->errorValue, event->client->errorValue);
>+        free(event);
>+        return;
>+    }
>+
>+    if ( event->client->clientGone) {
>+        ErrorF("radeon_dri2_frame_event_handler: ERROR : discard event as client is gone\n");
>+        free(event);
>+        return;
>+    }
>+
>     status = dixLookupDrawable(&drawable, event->drawable_id, serverClient,
>                                M_ANY, DixWriteAccess);
>     if (status != Success) {

Actions: View | Splinter Review

Attachments on bug 29065: 37054 | 37055 | 38119 | 38139 | 38209 | 38210 | 38211 | 38484 | 38703 | 38943 | 39128 | 39258

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.