Attachment 37172 Details for Bug 13124 – Proposed patch

[patch] Proposed patch

0001-aliasing-use-new-public_set_alias.patch (text/plain), 2.36 KB, created by Felipe Contreras on 2010-07-18 06:42:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Felipe Contreras

Created: 2010-07-18 06:42:52 UTC

Size: 2.36 KB

patch

obsolete

>From 210ec7bafdf69ced053150cd25e0abc33c6cb659 Mon Sep 17 00:00:00 2001
>From: Felipe Contreras <felipe.contreras@gmail.com>
>Date: Fri, 15 Jan 2010 02:27:32 +0200
>Subject: [PATCH] aliasing: use new public_set_alias()
>
>libpurple finally implemented it on 2.7.0. We might want to report
>errors somehow.
>
>Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>---
> src/connection-aliasing.c |   43 ++++++++++++++++++++++++++++++++++++++++---
> 1 files changed, 40 insertions(+), 3 deletions(-)
>
>diff --git a/src/connection-aliasing.c b/src/connection-aliasing.c
>index 07332bc..12a5e9d 100644
>--- a/src/connection-aliasing.c
>+++ b/src/connection-aliasing.c
>@@ -177,6 +177,42 @@ struct _g_hash_table_foreach_all_in_my_brain
> };
> 
> static void
>+set_alias_succeess_cb (PurpleAccount *account,
>+                       const char *new_alias)
>+{
>+    TpBaseConnection *base_conn;
>+    GPtrArray *aliases;
>+    GValue entry = {0, };
>+
>+    base_conn = ACCOUNT_GET_TP_BASE_CONNECTION (account);
>+
>+    g_value_init (&entry, HAZE_TP_ALIAS_PAIR_TYPE);
>+    g_value_take_boxed (&entry,
>+        dbus_g_type_specialized_construct (HAZE_TP_ALIAS_PAIR_TYPE));
>+
>+    dbus_g_type_struct_set (&entry,
>+        0, base_conn->self_handle,
>+        1, new_alias,
>+        G_MAXUINT);
>+
>+    aliases = g_ptr_array_sized_new (1);
>+    g_ptr_array_add (aliases, g_value_get_boxed (&entry));
>+
>+    tp_svc_connection_interface_aliasing_emit_aliases_changed (base_conn,
>+        aliases);
>+
>+    g_value_unset (&entry);
>+    g_ptr_array_free (aliases, TRUE);
>+}
>+
>+static void
>+set_alias_failure_cb (PurpleAccount *account,
>+                      const char *error)
>+{
>+    DEBUG ("couldn't set alias: %s\n", error);
>+}
>+
>+static void
> set_aliases_foreach (gpointer key,
>                      gpointer value,
>                      gpointer user_data)
>@@ -198,9 +234,10 @@ set_aliases_foreach (gpointer key,
>     }
>     else if (handle == TP_BASE_CONNECTION (data->conn)->self_handle)
>     {
>-        g_set_error (&error, TP_ERRORS, TP_ERROR_NOT_IMPLEMENTED,
>-            "Sadly, there's no general API in libpurple to set your own "
>-            "server alias.");
>+        purple_account_set_public_alias (data->conn->account,
>+                                         new_alias,
>+                                         set_alias_succeess_cb,
>+                                         set_alias_failure_cb);
>     }
>     else
>     {
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 13124: 37172

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.