Attachment 37382 Details for Bug 29248 – Clear any previous dither mode

[patch] Clear any previous dither mode

0001-drm-i915-Clear-any-existing-dither-mode-prior-to-ena.patch (text/plain), 1.43 KB, created by Chris Wilson on 2010-07-25 15:10:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2010-07-25 15:10:29 UTC

Size: 1.43 KB

patch

obsolete

>From 0327aac6f141e83c4235c20c2db1e84d7067060e Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Sun, 25 Jul 2010 23:03:16 +0100
>Subject: [PATCH] drm/i915: Clear any existing dither mode prior to enabling spatial dithering
>
>We cannot the initial configuration set by the BIOS not to have a dither
>mode enabled which conflicts with our enabling the Spatial Temporal 1
>dither mode for PCH. In particular, the BIOS may either enable temporal
>dithering or the Spatial Temporal 2 with the result that we enable pure
>temporal dithering. Temporal dithering looks bad and is perceived as a
>flicker.
>
>Fixes:
>
>  Bug 29248 - [Arrandale] Annoying flicker on internal panel, goes away
>              after suspend to RAM
>  https://bugs.freedesktop.org/show_bug.cgi?id=29248
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/intel_display.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index 7133436..fb6568b 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -3925,6 +3925,7 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
> 			if (dev_priv->lvds_dither) {
> 				if (HAS_PCH_SPLIT(dev)) {
> 					pipeconf |= PIPE_ENABLE_DITHER;
>+					pipeconf &= ~PIPE_DITHER_TYPE_MASK;
> 					pipeconf |= PIPE_DITHER_TYPE_ST01;
> 				} else
> 					lvds |= LVDS_ENABLE_DITHER;
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 29248: 37373 | 37374 | 37375 | 37376 | 37377 | 37378 | 37379 | 37380 | 37382 | 37405

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.