Attachment 37702 Details for Bug 29407 – Use fneg instead of neg when inverting the sign of floats

Use fneg instead of neg when inverting the sign of floats

tgsi_soa_float.patch (text/plain), 1.21 KB, created by steckdenis on 2010-08-08 07:44:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: steckdenis

Created: 2010-08-08 07:44:55 UTC

Size: 1.21 KB

patch

obsolete

>diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
>index 2123683..6dc2f24 100644
>--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
>+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
>@@ -506,6 +506,7 @@ emit_fetch(
>    const unsigned chan_index )
> {
>    const struct tgsi_full_src_register *reg = &inst->Src[src_op];
>+   const struct lp_type type = bld->base.type;
>    const unsigned swizzle =
>       tgsi_util_get_full_src_register_swizzle(reg, chan_index);
>    LLVMValueRef res;
>@@ -612,11 +613,17 @@ emit_fetch(
>    case TGSI_UTIL_SIGN_SET:
>       /* TODO: Use bitwese OR for floating point */
>       res = lp_build_abs( &bld->base, res );
>-      res = LLVMBuildNeg( bld->base.builder, res, "" );
>+      if (type.floating)
>+         res = LLVMBuildFNeg( bld->base.builder, res, "" );
>+      else
>+         res = LLVMBuildNeg( bld->base.builder, res, "" );
>       break;
> 
>    case TGSI_UTIL_SIGN_TOGGLE:
>-      res = LLVMBuildNeg( bld->base.builder, res, "" );
>+      if (type.floating)
>+         res = LLVMBuildFNeg( bld->base.builder, res, "" );
>+      else
>+         res = LLVMBuildNeg( bld->base.builder, res, "" );
>       break;
> 
>    case TGSI_UTIL_SIGN_KEEP:

Actions: View

Attachments on bug 29407: 37590 | 37630 | 37631 | 37636 | 37640 | 37642 | 37651 | 37652 | 37653 | 37702 | 37704 | 37705 | 37712 | 37746 | 37747 | 37748

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.