Attachment 37747 Details for Bug 29407 – gallivm: Even more type checking

[patch] gallivm: Even more type checking

0021-gallivm-Even-more-type-checking.patch (text/plain), 3.46 KB, created by nobled on 2010-08-09 14:23:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: nobled

Created: 2010-08-09 14:23:54 UTC

Size: 3.46 KB

patch

obsolete

>From 21e267fe32ef0737933dffdb59c264eefb669e01 Mon Sep 17 00:00:00 2001
>From: nobled <nobled@dreamwidth.org>
>Date: Mon, 9 Aug 2010 21:15:08 +0000
>Subject: [PATCH] gallivm: Even more type checking
>
>http://bugs.freedesktop.org/29407
>---
> src/gallium/auxiliary/gallivm/lp_bld_arit.c  |   12 +++++++++++-
> src/gallium/auxiliary/gallivm/lp_bld_logic.c |   15 +++++++++++++++
> 2 files changed, 26 insertions(+), 1 deletions(-)
>
>diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gallium/auxiliary/gallivm/lp_bld_arit.c
>index ec9b53b..860fbd8 100644
>--- a/src/gallium/auxiliary/gallivm/lp_bld_arit.c
>+++ b/src/gallium/auxiliary/gallivm/lp_bld_arit.c
>@@ -72,6 +72,9 @@ lp_build_min_simple(struct lp_build_context *bld,
>    const char *intrinsic = NULL;
>    LLVMValueRef cond;
> 
>+   assert(lp_check_value(type, a));
>+   assert(lp_check_value(type, b));
>+
>    /* TODO: optimize the constant case */
> 
>    if(type.width * type.length == 128) {
>@@ -118,6 +121,9 @@ lp_build_max_simple(struct lp_build_context *bld,
>    const char *intrinsic = NULL;
>    LLVMValueRef cond;
> 
>+   assert(lp_check_value(type, a));
>+   assert(lp_check_value(type, b));
>+
>    /* TODO: optimize the constant case */
> 
>    if(type.width * type.length == 128) {
>@@ -395,6 +401,10 @@ lp_build_mul_u8n(LLVMBuilderRef builder,
>    LLVMValueRef c8;
>    LLVMValueRef ab;
> 
>+   assert(!i16_type.floating);
>+   assert(lp_check_value(i16_type, a));
>+   assert(lp_check_value(i16_type, b));
>+
>    c8 = lp_build_const_int_vec(i16_type, 8);
>    
> #if 0
>@@ -848,8 +858,8 @@ lp_build_set_sign(struct lp_build_context *bld,
>                              ~((unsigned long long) 1 << (type.width - 1)));
>    LLVMValueRef val, res;
> 
>-   assert(lp_check_value(type, a));
>    assert(type.floating);
>+   assert(lp_check_value(type, a));
> 
>    /* val = reinterpret_cast<int>(a) */
>    val = LLVMBuildBitCast(bld->builder, a, int_vec_type, "");
>diff --git a/src/gallium/auxiliary/gallivm/lp_bld_logic.c b/src/gallium/auxiliary/gallivm/lp_bld_logic.c
>index ab4ddb8..96f8e21 100644
>--- a/src/gallium/auxiliary/gallivm/lp_bld_logic.c
>+++ b/src/gallium/auxiliary/gallivm/lp_bld_logic.c
>@@ -83,6 +83,8 @@ lp_build_compare(LLVMBuilderRef builder,
> 
>    assert(func >= PIPE_FUNC_NEVER);
>    assert(func <= PIPE_FUNC_ALWAYS);
>+   assert(lp_check_value(type, a));
>+   assert(lp_check_value(type, b));
> 
>    if(func == PIPE_FUNC_NEVER)
>       return zeros;
>@@ -374,6 +376,9 @@ lp_build_select_bitwise(struct lp_build_context *bld,
>    struct lp_type type = bld->type;
>    LLVMValueRef res;
> 
>+   assert(lp_check_value(type, a));
>+   assert(lp_check_value(type, b));
>+
>    if (a == b) {
>       return a;
>    }
>@@ -419,6 +424,9 @@ lp_build_select(struct lp_build_context *bld,
>    struct lp_type type = bld->type;
>    LLVMValueRef res;
> 
>+   assert(lp_check_value(type, a));
>+   assert(lp_check_value(type, b));
>+
>    if(a == b)
>       return a;
> 
>@@ -484,6 +492,9 @@ lp_build_select_aos(struct lp_build_context *bld,
>    const unsigned n = type.length;
>    unsigned i, j;
> 
>+   assert(lp_check_value(type, a));
>+   assert(lp_check_value(type, b));
>+
>    if(a == b)
>       return a;
>    if(cond[0] && cond[1] && cond[2] && cond[3])
>@@ -539,7 +550,11 @@ lp_build_select_aos(struct lp_build_context *bld,
> LLVMValueRef
> lp_build_andc(struct lp_build_context *bld, LLVMValueRef a, LLVMValueRef b)
> {
>+   assert(lp_check_value(bld->type, a));
>+   assert(lp_check_value(bld->type, b));
>+
>    b = LLVMBuildNot(bld->builder, b, "");
>    b = LLVMBuildAnd(bld->builder, a, b, "");
>+
>    return b;
> }
>-- 
>1.5.4.3
>

Actions: View | Splinter Review

Attachments on bug 29407: 37590 | 37630 | 37631 | 37636 | 37640 | 37642 | 37651 | 37652 | 37653 | 37702 | 37704 | 37705 | 37712 | 37746 | 37747 | 37748

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.