Attachment 37899 Details for Bug 29384 – possible fix

[patch] possible fix

0001-drm-radeon-kms-pm-bail-early-if-nothing-s-changing.patch (text/plain), 1.20 KB, created by Alex Deucher on 2010-08-16 07:10:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2010-08-16 07:10:58 UTC

Size: 1.20 KB

patch

obsolete

>From 9dc9821653564e892bf3be02018fe259939ac2cf Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Thu, 12 Aug 2010 19:14:12 -0400
>Subject: [PATCH] drm/radeon/kms/pm: bail early if nothing's changing
>
>If we aren't changing the power state, no need to take
>locks and schedule fences, etc. The driver locking in
>general needs a review.
>
>Should fix:
>https://bugs.freedesktop.org/show_bug.cgi?id=29140
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>---
> drivers/gpu/drm/radeon/radeon_pm.c |    5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
>index a3d25f4..9a8031b 100644
>--- a/drivers/gpu/drm/radeon/radeon_pm.c
>+++ b/drivers/gpu/drm/radeon/radeon_pm.c
>@@ -226,6 +226,11 @@ static void radeon_pm_set_clocks(struct radeon_device *rdev)
> {
> 	int i;
> 
>+	/* no need to take locks, etc. if nothing's going to change */
>+	if ((rdev->pm.requested_clock_mode_index == rdev->pm.current_clock_mode_index) &&
>+	    (rdev->pm.requested_power_state_index == rdev->pm.current_power_state_index))
>+		return;
>+
> 	mutex_lock(&rdev->ddev->struct_mutex);
> 	mutex_lock(&rdev->vram_mutex);
> 	mutex_lock(&rdev->cp.mutex);
>-- 
>1.7.1.1
>

Actions: View | Splinter Review

Attachments on bug 29384: 37543 | 37544 | 37545 | 37667 | 37668 | 37675 | 37899

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.