Attachment 37950 Details for Bug 29645 – Rewriting of first patch based on more correct touchscreen detection

[patch] Rewriting of first patch based on more correct touchscreen detection

0002-Ignore-BTN_TOOL_PEN-on-touchscreens-so-that-taps-won.patch (text/plain), 1007 bytes, created by Anisse Astier on 2010-08-18 07:30:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Anisse Astier

Created: 2010-08-18 07:30:29 UTC

Size: 1007 bytes

patch

obsolete

>From: Anisse Astier <anisse@astier.eu>
>Date: Wed, 18 Aug 2010 15:39:08 +0200
>Subject: [PATCH 2/2] Ignore BTN_TOOL_PEN on touchscreens so that taps won't be missed.
>
>Some touchscreens will report acurate events regardless of tool.
>Ignoring these events, will cause taps to be at previous coordinates.
>Ignore BTN_TOOL_PEN so that "tool" will stay always TRUE and allow these
>touchsreens to function propely
>
>Signed-off-by: Anisse Astier <anisse@astier.eu>
>---
> src/evdev.c |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
>diff --git a/src/evdev.c b/src/evdev.c
>index 6d7308e..5df5888 100644
>--- a/src/evdev.c
>+++ b/src/evdev.c
>@@ -618,6 +618,10 @@ EvdevProcessKeyEvent(InputInfoPtr pInfo, struct input_event *ev)
> 
>     switch (ev->code) {
>         case BTN_TOOL_PEN:
>+            if (pEvdev->flags & EVDEV_TOUCHSCREEN)
>+                break;
>+            /* Intentional fallthrough! */
>+
>         case BTN_TOOL_RUBBER:
>         case BTN_TOOL_BRUSH:
>         case BTN_TOOL_PENCIL:
>-- 
>1.7.0.6
>

Actions: View | Splinter Review

Attachments on bug 29645: 37948 | 37949 | 37950 | 37953

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.