Attachment 37953 Details for Bug 29645 – Another approach: narrow special treatment to tablets

[patch] Another approach: narrow special treatment to tablets

0002-Narrow-usage-of-tool-filtering-to-tablets.patch (text/plain), 1.41 KB, created by Anisse Astier on 2010-08-18 07:47:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Anisse Astier

Created: 2010-08-18 07:47:16 UTC

Size: 1.41 KB

patch

obsolete

>From: Anisse Astier <anisse@astier.eu>
>Date: Wed, 18 Aug 2010 15:28:28 +0200
>Subject: [PATCH 2/2] Narrow usage of "tool" filtering to tablets
>
>Some touchscreens will report accurate absolute events regardless of tool.
>Ignoring these events, will cause taps to be at previous coordinates.
>
>Narrow usage of "tool" to tablets so that this kind of touchscreen can
>work properly.
>
>Signed-off-by: Anisse Astier <anisse@astier.eu>
>---
> src/evdev.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/evdev.c b/src/evdev.c
>index 6d7308e..f0b0f78 100644
>--- a/src/evdev.c
>+++ b/src/evdev.c
>@@ -462,7 +462,7 @@ EvdevProcessValuators(InputInfoPtr pInfo, int v[MAX_VALUATORS], int *num_v,
>      * initialized to 1 so devices that doesn't use this scheme still
>      * just works.
>      */
>-    else if (pEvdev->abs && pEvdev->tool) {
>+    else if (pEvdev->abs && (pEvdev->tool || !(pEvdev->flags & EVDEV_TABLET))) {
>         memcpy(v, pEvdev->vals, sizeof(int) * pEvdev->num_vals);
> 
>         if (pEvdev->swap_axes) {
>@@ -674,7 +674,7 @@ EvdevPostAbsoluteMotionEvents(InputInfoPtr pInfo, int *num_v, int *first_v,
>      * initialized to 1 so devices that doesn't use this scheme still
>      * just works.
>      */
>-    if (pEvdev->abs && pEvdev->tool) {
>+    if (pEvdev->abs && (pEvdev->tool || !(pEvdev->flags & EVDEV_TABLET))) {
>         xf86PostMotionEventP(pInfo->dev, TRUE, *first_v, *num_v, v);
>     }
> }
>-- 
>1.7.0.6
>

Actions: View | Splinter Review

Attachments on bug 29645: 37948 | 37949 | 37950 | 37953

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.