Attachment 38063 Details for Bug 28823 – swap 2 * numAttribs ints, not just numAttribs

[patch] swap 2 * numAttribs ints, not just numAttribs

0005-glx-swap-the-request-arrays-entirely-not-just-half-o.patch (text/plain), 2.39 KB, created by Julien Cristau on 2010-08-22 08:34:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julien Cristau

Created: 2010-08-22 08:34:16 UTC

Size: 2.39 KB

patch

obsolete

>From 1ca1ccf5f61db71e9c0657a0b74ddd4a15fc438f Mon Sep 17 00:00:00 2001
>From: Julien Cristau <jcristau@debian.org>
>Date: Sun, 22 Aug 2010 16:20:45 +0100
>Subject: [PATCH 5/5] glx: swap the request arrays entirely, not just half of them
>
>Various glx request include a list of pairs of attributes.  We were only
>swapping the first half.
>
>Signed-off-by: Julien Cristau <jcristau@debian.org>
>---
> glx/glxcmdsswap.c |   10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/glx/glxcmdsswap.c b/glx/glxcmdsswap.c
>index cca9843..cbd9b88 100644
>--- a/glx/glxcmdsswap.c
>+++ b/glx/glxcmdsswap.c
>@@ -322,7 +322,7 @@ int __glXDispSwap_CreatePixmap(__GLXclientState *cl, GLbyte *pc)
> 
>     REQUEST_FIXED_SIZE(xGLXCreatePixmapReq, req->numAttribs << 3);
>     attribs = (CARD32*)(req + 1);
>-    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs);
>+    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs << 1);
> 
>     return __glXDisp_CreatePixmap(cl, pc);
> }
>@@ -403,7 +403,7 @@ int __glXDispSwap_CreatePbuffer(__GLXclientState *cl, GLbyte *pc)
> 
>     REQUEST_FIXED_SIZE(xGLXCreatePbufferReq, req->numAttribs << 3);
>     attribs = (CARD32*)(req + 1);
>-    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs);
>+    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs << 1);
> 
>     return __glXDisp_CreatePbuffer(cl, pc);
> }
>@@ -467,7 +467,7 @@ int __glXDispSwap_ChangeDrawableAttributes(__GLXclientState *cl, GLbyte *pc)
> 
>     REQUEST_FIXED_SIZE(xGLXChangeDrawableAttributesReq, req->numAttribs << 3);
>     attribs = (CARD32*)(req + 1);
>-    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs);
>+    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs << 1);
> 
>     return __glXDisp_ChangeDrawableAttributes(cl, pc);
> }
>@@ -489,7 +489,7 @@ int __glXDispSwap_ChangeDrawableAttributesSGIX(__GLXclientState *cl,
> 
>     REQUEST_FIXED_SIZE(xGLXChangeDrawableAttributesSGIXReq, req->numAttribs << 3);
>     attribs = (CARD32*)(req + 1);
>-    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs);
>+    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs << 1);
> 
>     return __glXDisp_ChangeDrawableAttributesSGIX(cl, pc);
> }
>@@ -512,7 +512,7 @@ int __glXDispSwap_CreateWindow(__GLXclientState *cl, GLbyte *pc)
> 
>     REQUEST_FIXED_SIZE(xGLXCreateWindowReq, req->numAttribs << 3);
>     attribs = (CARD32*)(req + 1);
>-    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs);
>+    __GLX_SWAP_INT_ARRAY(attribs, req->numAttribs << 1);
> 
>     return __glXDisp_CreateWindow(cl, pc);
> }
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 28823: 36729 | 36730 | 36731 | 38061 | 38062 | 38063 | 40181 | 40185

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.