Attachment 38406 Details for Bug 29985 – possible fix

[patch] possible fix

0001-drm-radeon-kms-fix-tv-out-on-avivo-asics.patch (text/plain), 2.41 KB, created by Alex Deucher on 2010-09-03 10:06:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2010-09-03 10:06:06 UTC

Size: 2.41 KB

patch

obsolete

>From 75e58bdd96435d56246b71408a42e54a5ce76592 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Fri, 3 Sep 2010 13:04:06 -0400
>Subject: [PATCH] drm/radeon/kms: fix tv-out on avivo asics
>
>underscan support seems to have regressed tv-out.
>
>Should fix:
>https://bugs.freedesktop.org/show_bug.cgi?id=29985
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>---
> drivers/gpu/drm/radeon/atombios_crtc.c |   26 +++++++++++++++++++++++---
> 1 files changed, 23 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
>index 71b3150..464a81a 100644
>--- a/drivers/gpu/drm/radeon/atombios_crtc.c
>+++ b/drivers/gpu/drm/radeon/atombios_crtc.c
>@@ -332,6 +332,11 @@ static void atombios_crtc_set_timing(struct drm_crtc *crtc,
> 	args.usV_SyncWidth =
> 		cpu_to_le16(mode->crtc_vsync_end - mode->crtc_vsync_start);
> 
>+	args.ucOverscanRight = radeon_crtc->h_border;
>+	args.ucOverscanLeft = radeon_crtc->h_border;
>+	args.ucOverscanBottom = radeon_crtc->v_border;
>+	args.ucOverscanTop = radeon_crtc->v_border;
>+
> 	if (mode->flags & DRM_MODE_FLAG_NVSYNC)
> 		misc |= ATOM_VSYNC_POLARITY;
> 	if (mode->flags & DRM_MODE_FLAG_NHSYNC)
>@@ -1211,8 +1216,18 @@ int atombios_crtc_mode_set(struct drm_crtc *crtc,
> 	struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc);
> 	struct drm_device *dev = crtc->dev;
> 	struct radeon_device *rdev = dev->dev_private;
>+	struct drm_encoder *encoder;
>+	bool is_tvcv = false;
> 
>-	/* TODO color tiling */
>+	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
>+		/* find tv std */
>+		if (encoder->crtc == crtc) {
>+			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
>+			if (radeon_encoder->active_device &
>+			    (ATOM_DEVICE_TV_SUPPORT | ATOM_DEVICE_CV_SUPPORT))
>+				is_tvcv = true;
>+		}
>+	}
> 
> 	atombios_disable_ss(crtc);
> 	/* always set DCPLL */
>@@ -1221,9 +1236,14 @@ int atombios_crtc_mode_set(struct drm_crtc *crtc,
> 	atombios_crtc_set_pll(crtc, adjusted_mode);
> 	atombios_enable_ss(crtc);
> 
>-	if (ASIC_IS_AVIVO(rdev))
>+	if (ASIC_IS_DCE4(rdev))
> 		atombios_set_crtc_dtd_timing(crtc, adjusted_mode);
>-	else {
>+	else if (ASIC_IS_AVIVO(rdev)) {
>+		if (is_tvcv)
>+			atombios_crtc_set_timing(crtc, adjusted_mode);
>+		else
>+			atombios_set_crtc_dtd_timing(crtc, adjusted_mode);
>+	} else {
> 		atombios_crtc_set_timing(crtc, adjusted_mode);
> 		if (radeon_crtc->crtc_id == 0)
> 			atombios_set_crtc_dtd_timing(crtc, adjusted_mode);
>-- 
>1.7.1.1
>

Actions: View | Splinter Review

Attachments on bug 29985: 38406

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.