Attachment 38557 Details for Bug 29857 – Only decouple fb when calling mode_set*()

[patch] Only decouple fb when calling mode_set*()

0001-drm-Only-decouple-the-old_fb-from-the-crtc-is-we-cal.patch (text/plain), 1.38 KB, created by Chris Wilson on 2010-09-08 08:32:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2010-09-08 08:32:57 UTC

Size: 1.38 KB

patch

obsolete

>From 18b5c3772a658e84d4c9472640dd9605e522d770 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Wed, 8 Sep 2010 16:12:33 +0100
>Subject: [PATCH 1/2] drm: Only decouple the old_fb from the crtc is we call mode_set*
>
>Otherwise when disabling the output we switch to the new fb (which is
>likely NULL) and skip the call to mode_set -- leaking driver private
>state on the old_fb.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29857
>Reported-by: Sitsofe Wheeler <sitsofe@yahoo.com>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/drm_crtc_helper.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
>index 7e31d43..e92ecda 100644
>--- a/drivers/gpu/drm/drm_crtc_helper.c
>+++ b/drivers/gpu/drm/drm_crtc_helper.c
>@@ -633,13 +633,13 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
> 		mode_changed = true;
> 
> 	if (mode_changed) {
>-		old_fb = set->crtc->fb;
>-		set->crtc->fb = set->fb;
> 		set->crtc->enabled = (set->mode != NULL);
> 		if (set->mode != NULL) {
> 			DRM_DEBUG_KMS("attempting to set mode from"
> 					" userspace\n");
> 			drm_mode_debug_printmodeline(set->mode);
>+			old_fb = set->crtc->fb;
>+			set->crtc->fb = set->fb;
> 			if (!drm_crtc_helper_set_mode(set->crtc, set->mode,
> 						      set->x, set->y,
> 						      old_fb)) {
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 29857: 38242 | 38243 | 38244 | 38245 | 38246 | 38247 | 38248 | 38249 | 38250 | 38256 | 38257 | 38557 | 38559 | 38567 | 38589 | 42634

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.