Attachment 39022 Details for Bug 30416 – Fix the compiler error

[patch] Fix the compiler error

0001-r300-compiler-Don-t-use-rc_error-unless-the-error-is.patch (text/plain), 1.22 KB, created by Tom Stellard on 2010-09-28 09:57:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tom Stellard

Created: 2010-09-28 09:57:49 UTC

Size: 1.22 KB

patch

obsolete

>From dee5b0cb9a59a70ac4389243f6f3af0c748be5ee Mon Sep 17 00:00:00 2001
>From: Tom Stellard <tstellar@gmail.com>
>Date: Tue, 28 Sep 2010 09:57:18 -0700
>Subject: [PATCH] r300/compiler: Don't use rc_error() unless the error is unrecoverable.
>
>---
> .../dri/r300/compiler/radeon_emulate_loops.c       |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/r300/compiler/radeon_emulate_loops.c b/src/mesa/drivers/dri/r300/compiler/radeon_emulate_loops.c
>index cd4fcba..02a52f9 100644
>--- a/src/mesa/drivers/dri/r300/compiler/radeon_emulate_loops.c
>+++ b/src/mesa/drivers/dri/r300/compiler/radeon_emulate_loops.c
>@@ -386,8 +386,6 @@ static int build_loop_info(struct radeon_compiler * c, struct loop_info * loop,
> 			case RC_OPCODE_SNE:
> 				break;
> 			default:
>-				rc_error(c, "%s: expected conditional",
>-								__FUNCTION__);
> 				return 0;
> 			}
> 			loop->Cond = loop->If->Prev;
>@@ -431,8 +429,10 @@ static int transform_loop(struct emulate_loop_state * s,
> 
> 	loop = &s->Loops[s->LoopCount++];
> 
>-	if (!build_loop_info(s->C, loop, inst))
>+	if (!build_loop_info(s->C, loop, inst)) {
>+		rc_error(s->C, "Failed to build loop info\n");
> 		return 0;
>+	}
> 
> 	if(try_unroll_loop(s->C, loop)){
> 		return 1;
>-- 
>1.7.2.2
>

Actions: View | Splinter Review

Attachments on bug 30416: 39022

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.