Attachment 39081 Details for Bug 30515 – Patch to ensure that the helper is declared running before a handler can fire

[patch] Patch to ensure that the helper is declared running before a handler can fire

04_fix_agent_helper_race (text/plain), 1.04 KB, created by James Westby on 2010-09-30 13:49:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: James Westby

Created: 2010-09-30 13:49:34 UTC

Size: 1.04 KB

patch

obsolete

>Index: policykit-1-0.94/src/polkitagent/polkitagentsession.c
>===================================================================
>--- policykit-1-0.94.orig/src/polkitagent/polkitagentsession.c	2009-10-12 22:04:34.000000000 +0100
>+++ policykit-1-0.94/src/polkitagent/polkitagentsession.c	2009-10-12 22:04:41.000000000 +0100
>@@ -514,14 +514,14 @@
>       goto error;
>     }
> 
>-  session->child_watch_id = g_child_watch_add (session->child_pid, child_watch_func, session);
>-  session->child_stdout_channel = g_io_channel_unix_new (session->child_stdout);
>-  session->child_stdout_watch_id = g_io_add_watch (session->child_stdout_channel, G_IO_IN, io_watch_have_data, session);
>-
>   session->success = FALSE;
> 
>   session->helper_is_running = TRUE;
> 
>+  session->child_watch_id = g_child_watch_add (session->child_pid, child_watch_func, session);
>+  session->child_stdout_channel = g_io_channel_unix_new (session->child_stdout);
>+  session->child_stdout_watch_id = g_io_add_watch (session->child_stdout_channel, G_IO_IN, io_watch_have_data, session);
>+
>   return;
> 
> error:

Actions: View | Splinter Review

Attachments on bug 30515: 39080 | 39081 | 39082

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.