Attachment 39168 Details for Bug 30612 – Could-be fix

[patch] Could-be fix

0001-xcb-Do-not-return-value-in-void-function.patch (text/plain), 1.18 KB, created by Andrea Canciani on 2010-10-05 01:41:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrea Canciani

Created: 2010-10-05 01:41:57 UTC

Size: 1.18 KB

patch

obsolete

>From f20814e07e7032c14f273d712f35e19addfdae80 Mon Sep 17 00:00:00 2001
>From: Andrea Canciani <ranma42@gmail.com>
>Date: Tue, 5 Oct 2010 10:36:38 +0200
>Subject: [PATCH] xcb: Do not return value in void function
>
>Sun Studio Compiler complains:
>"cairo-xcb-surface.c", line 585: void function cannot return value
>even if the returned value is void.
>Some minor code restructuring removes the issue.
>---
> src/cairo-xcb-surface.c |   10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/src/cairo-xcb-surface.c b/src/cairo-xcb-surface.c
>index 9c2d3a7..d852f50 100644
>--- a/src/cairo-xcb-surface.c
>+++ b/src/cairo-xcb-surface.c
>@@ -580,12 +580,10 @@ _cairo_xcb_surface_release_source_image (void *abstract_surface,
> {
>     cairo_xcb_surface_t *surface = abstract_surface;
> 
>-    if (surface->drm != NULL && ! surface->marked_dirty) {
>-	return _cairo_surface_release_source_image (surface->drm,
>-						    image, image_extra);
>-    }
>-
>-    cairo_surface_destroy (&image->base);
>+    if (surface->drm != NULL && !surface->marked_dirty)
>+	_cairo_surface_release_source_image (surface->drm, image, image_extra);
>+    else
>+	cairo_surface_destroy (&image->base);
> }
> 
> static cairo_bool_t
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 30612: 39168

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.