Attachment 39182 Details for Bug 30631 – ContactInfo: Add flag for fields that are overwritten by nickname

[patch] ContactInfo: Add flag for fields that are overwritten by nickname

ContactInfo-Add-flag-for-fields-that-are-overwritt.patch (text/plain), 2.26 KB, created by Jonathon Jongsma on 2010-10-05 10:01:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathon Jongsma

Created: 2010-10-05 10:01:47 UTC

Size: 2.26 KB

patch

obsolete

>From 91e50d4349b51e306112fc1276ab5de5112cc8cb Mon Sep 17 00:00:00 2001
>From: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
>Date: Tue, 5 Oct 2010 11:55:52 -0500
>Subject: [PATCH] ContactInfo: Add flag for fields that are overwritten by nickname
>
>It's likely that clients will want to expose the user's nickname and their
>contact info in the same place for editing.  Howevever, many CMs map one of the
>ContactInfo fields to the user's nickname, so editing these two fields
>independantly at the same time results in surprising behavior.  Adding a flag to
>the ContactInfo field will allow clients to hide these duplicate fields when
>presenting them together.
>
>Fixes: fd.o#30631
>---
> spec/Connection_Interface_Contact_Info.xml |   18 ++++++++++++++++++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
>diff --git a/spec/Connection_Interface_Contact_Info.xml b/spec/Connection_Interface_Contact_Info.xml
>index ce77a56..87baa83 100644
>--- a/spec/Connection_Interface_Contact_Info.xml
>+++ b/spec/Connection_Interface_Contact_Info.xml
>@@ -330,6 +330,24 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
>           whenever contacts' information changes.
>         </tp:docstring>
>       </tp:flag>
>+
>+      <tp:flag suffix="Overwritten_By_Nickname" value="3">
>+        <tp:docstring>
>+          Indicates that this field will be overwritten when the user's alias is changed with <tp:dbus-ref
>+        namespace="org.freedesktop.Telepathy.Connection.Interface.Aliasing">SetAliases</tp:dbus-ref>
>+          or when the Account's <tp:dbus-ref
>+              namespace="org.freedesktop.Telepathy.Account">Nickname</tp:dbus-ref>
>+          is updated.  Because of this, clients that allow the editing of the
>+          Alias and the ContactInfo in the same location should hide this field.
>+        <tp:rationale>
>+          If a client allowed the user to edit both the nickname and the
>+          ContactInfo field together, the user could set them to two different
>+          values even though they map to the same property.  This would result
>+          in surprising behavior where the second value would win over the
>+          first.
>+        </tp:rationale>
>+        </tp:docstring>
>+      </tp:flag>
>     </tp:flags>
> 
>     <tp:simple-type name="VCard_Field" type="s">
>-- 
>1.7.1

Actions: View | Splinter Review

Attachments on bug 30631: 39182 | 39183 | 39187

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.