Attachment 39253 Details for Bug 24307 – Implement message type in match_rule_to_string

[patch] Implement message type in match_rule_to_string

05-message-type-in-match_rule_to_string.patch (text/plain), 1.84 KB, created by Christian Dywan on 2010-10-07 05:25:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Dywan

Created: 2010-10-07 05:25:10 UTC

Size: 1.84 KB

patch

obsolete

>From b658ae66dc20156d9cdea80af29c79854fc171d5 Mon Sep 17 00:00:00 2001
>From: Alban Crequy <alban.crequy@collabora.co.uk>
>Date: Wed, 6 Oct 2010 13:12:32 +0200
>Subject: [PATCH 1/2] Implement message type in match_rule_to_string
>
>See https://bugs.freedesktop.org/show_bug.cgi?id=24307
>
>---
> bus/signals.c |   33 ++++++++++++++++++++++++++++++---
> 1 files changed, 30 insertions(+), 3 deletions(-)
>
>diff --git a/bus/signals.c b/bus/signals.c
>index 6f97b2b..3ff7b8c 100644
>--- a/bus/signals.c
>+++ b/bus/signals.c
>@@ -135,9 +135,36 @@ match_rule_to_string (BusMatchRule *rule)
>   
>   if (rule->flags & BUS_MATCH_MESSAGE_TYPE)
>     {
>-      /* FIXME make type readable */
>-      if (!_dbus_string_append_printf (&str, "type='%d'", rule->message_type))
>-        goto nomem;
>+      if (rule->message_type == DBUS_MESSAGE_TYPE_INVALID)
>+        {
>+          if (!_dbus_string_append_printf (&str, "type='INVALID'"))
>+            goto nomem;
>+        }
>+      else if (rule->message_type == DBUS_MESSAGE_TYPE_METHOD_CALL)
>+        {
>+          if (!_dbus_string_append_printf (&str, "type='method_call'"))
>+            goto nomem;
>+        }
>+      else if (rule->message_type == DBUS_MESSAGE_TYPE_METHOD_RETURN)
>+        {
>+          if (!_dbus_string_append_printf (&str, "type='method_return'"))
>+            goto nomem;
>+        }
>+      else if (rule->message_type == DBUS_MESSAGE_TYPE_ERROR)
>+        {
>+          if (!_dbus_string_append_printf (&str, "type='error'"))
>+            goto nomem;
>+        }
>+      else if (rule->message_type == DBUS_MESSAGE_TYPE_SIGNAL)
>+        {
>+          if (!_dbus_string_append_printf (&str, "type='signal'"))
>+            goto nomem;
>+        }
>+      else
>+        {
>+          if (!_dbus_string_append_printf (&str, "type='%d'", rule->message_type))
>+            goto nomem;
>+        }
>     }
> 
>   if (rule->flags & BUS_MATCH_INTERFACE)
>-- 
>1.7.2.3
>

Actions: View | Splinter Review

Attachments on bug 24307: 30040 | 30041 | 39253 | 39254 | 102017 | 102858 | 106796 | 106797 | 106798 | 106799 | 106800 | 106801 | 106802 | 106846

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.