Attachment 39315 Details for Bug 30738 – Take down DP link

[patch] Take down DP link

0001-drm-i915-dp-down-the-DP-link-even-if-the-reg-indicat.patch (text/plain), 1.85 KB, created by Chris Wilson on 2010-10-09 15:10:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2010-10-09 15:10:11 UTC

Size: 1.85 KB

patch

obsolete

>From 841c95ed99e734fc49d8b674868a3e7c7f55c6dc Mon Sep 17 00:00:00 2001
>From: Jesse Barnes <jbarnes@virtuousgeek.org>
>Date: Fri, 8 Oct 2010 10:35:55 -0700
>Subject: [PATCH] drm/i915/dp: down the DP link even if the reg indicates it's already down
>
>Since the PLL may still be on, and the training pattern may not be
>correct.  Fixes suspend/resume on my PCH eDP test system.
>
>Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/intel_dp.c |   14 ++++++--------
> 1 files changed, 6 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>index 128c2fe..befe57a 100644
>--- a/drivers/gpu/drm/i915/intel_dp.c
>+++ b/drivers/gpu/drm/i915/intel_dp.c
>@@ -925,8 +925,7 @@ static void intel_dp_prepare(struct drm_encoder *encoder)
> 		else
> 			ironlake_edp_pll_off(encoder);
> 	}
>-	if (dp_reg & DP_PORT_EN)
>-		intel_dp_link_down(intel_dp);
>+	intel_dp_link_down(intel_dp);
> }
> 
> static void intel_dp_commit(struct drm_encoder *encoder)
>@@ -956,21 +955,20 @@ intel_dp_dpms(struct drm_encoder *encoder, int mode)
> 	if (mode != DRM_MODE_DPMS_ON) {
> 		if (is_edp(intel_dp))
> 			ironlake_edp_backlight_off(dev);
>-		if (dp_reg & DP_PORT_EN)
>-			intel_dp_link_down(intel_dp);
>+		intel_dp_link_down(intel_dp);
> 		if (is_edp(intel_dp))
> 			ironlake_edp_panel_off(dev);
> 		if (is_edp(intel_dp) && !is_pch_edp(intel_dp))
> 			ironlake_edp_pll_off(encoder);
> 	} else {
>+		if (is_edp(intel_dp))
>+			ironlake_edp_panel_on(intel_dp);
> 		if (!(dp_reg & DP_PORT_EN)) {
>-			if (is_edp(intel_dp))
>-				ironlake_edp_panel_on(intel_dp);
> 			intel_dp_start_link_train(intel_dp);
> 			intel_dp_complete_link_train(intel_dp);
>-			if (is_edp(intel_dp))
>-				ironlake_edp_backlight_on(dev);
> 		}
>+		if (is_edp(intel_dp))
>+			ironlake_edp_backlight_on(dev);
> 	}
> 	intel_dp->dpms_mode = mode;
> }
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 30738: 39312 | 39313 | 39315 | 39325 | 39326

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.