Attachment 39450 Details for Bug 30662 – patch updated to satisfy Simon's comments

[patch] patch updated to satisfy Simon's comments

0001-StreamHandler-Add-signals-specifying-the-type-of-DTM.patch (text/plain), 3.06 KB, created by Olivier Crête on 2010-10-14 10:05:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Crête

Created: 2010-10-14 10:05:18 UTC

Size: 3.06 KB

patch

obsolete

>From e879c53bb6bf1930a4d71d2c8472048286fe04ee Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Olivier=20Cr=C3=AAte?= <tester@tester.ca>
>Date: Wed, 6 Oct 2010 12:36:45 -0400
>Subject: [PATCH] StreamHandler: Add signals specifying the type of DTMF event to send
>
>Some protocols specify the type of DTMF event send and the payload type
>just at the time when the are sent. These signals should make these easier to implement.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=30662
>---
> spec/Media_Stream_Handler.xml |   40 ++++++++++++++++++++++++++++++++++++++--
> 1 files changed, 38 insertions(+), 2 deletions(-)
>
>diff --git a/spec/Media_Stream_Handler.xml b/spec/Media_Stream_Handler.xml
>index c9ae78f..ee59d94 100644
>--- a/spec/Media_Stream_Handler.xml
>+++ b/spec/Media_Stream_Handler.xml
>@@ -513,9 +513,9 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
>     </signal>
>     <signal name="StartTelephonyEvent"
>       tp:name-for-bindings="Start_Telephony_Event">
>-      <arg name="Event" type="y">
>+      <arg name="Event" type="y" tp:type="DTMF_Event">
>         <tp:docstring>
>-          A telephony event code as defined by RFC 4733.
>+          A telephony event code.
>         </tp:docstring>
>       </arg>
>       <tp:docstring>
>@@ -523,6 +523,42 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
>         over this stream until StopTelephonyEvent is called.
>       </tp:docstring>
>     </signal>
>+    <signal name="StartNamedTelephonyEvent"
>+      tp:name-for-bindings="Start_Named_Telephony_Event">
>+      <arg name="Event" type="y" tp:type="DTMF_Event">
>+        <tp:docstring>
>+          A telephony event code as defined by RFC 4733.
>+        </tp:docstring>
>+      </arg>
>+     <arg name="Codec_ID" type="u">
>+        <tp:docstring>
>+          The payload type to use when sending events. The value 0xFFFFFFFF
>+	  means to send with the already configured event type instead of using
>+	  the specified one.
>+        </tp:docstring>
>+      </arg>
>+      <tp:docstring>
>+        Request that a telephony event (as defined by RFC 4733) is transmitted
>+        over this stream until StopTelephonyEvent is called. This differs from
>+        StartTelephonyEvent in that you force the event to be transmitted
>+	as a RFC 4733 named event, not as sound. You can also force a specific
>+	Codec ID.
>+      </tp:docstring>
>+    </signal>
>+    <signal name="StartSoundTelephonyEvent"
>+      tp:name-for-bindings="Start_Sound_Telephony_Event">
>+      <arg name="Event" type="y" tp:type="DTMF_Event">
>+        <tp:docstring>
>+          A telephony event code as defined by RFC 4733.
>+        </tp:docstring>
>+      </arg>
>+      <tp:docstring>
>+        Request that a telephony event (as defined by RFC 4733) is transmitted
>+        over this stream until StopTelephonyEvent is called. This differs from
>+        StartTelephonyEvent in that you force the event to be transmitted
>+	as sound instead of as a named event.
>+      </tp:docstring>
>+    </signal>
>     <signal name="StopTelephonyEvent"
>       tp:name-for-bindings="Stop_Telephony_Event">
>       <tp:docstring>
>-- 
>1.7.2.3
>

Actions: View | Splinter Review

Attachments on bug 30662: 39237 | 39238 | 39241 | 39450

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.